Make PRR metadata required

kubernetes · May 4, 2021 · 724e7e9 · 724e7e9
1 parent 29a891b
commit 724e7e9
Showing 1 changed file with 0 additions and 3 deletions.
diff --git a/pkg/kepval/approval.go b/pkg/kepval/approval.go
@@ -105,20 +105,17 @@ func isPRRRequired(kep *api.Proposal) (required, missingMilestone, missingStage
 	missingStage = kep.IsMissingStage()
 
 	if kep.Status != "implementable" {
-		required = false
 		return required, missingMilestone, missingStage, nil
 	}
 
 	if missingMilestone {
-		required = false
 		// TODO: Make this a specialized error
 		logrus.Warnf("KEP %s is missing the latest milestone field. This will become a validation error in future releases.", kep.Number)
 
 		return required, missingMilestone, missingStage, nil
 	}
 
 	if missingStage {
-		required = false
 		// TODO: Make this a specialized error
 		logrus.Warnf("KEP %s is missing the stage field. This will become a validation error in future releases.", kep.Number)