Skip to content

Commit

Permalink
Resolve reviewer comments
Browse files Browse the repository at this point in the history
  • Loading branch information
danielye11 committed Oct 3, 2022
1 parent 822dae3 commit 4c9ac6d
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions keps/sig-node/2371-cri-pod-container-stats/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ as cAdvisor is fine tuned to perform in an adequate manner.
### Stats Summary API

#### CRI Implementation
The CRI implementation will need to be extended to support reporting the full set of container-level from the [Summary API](#summary-container-stats-object). A new GRPC call will also be added to the CRI that allows reporting for metrics currently exported by cAdvisor, but are outside the scope of the Summary API. This new GRPC call will return a Prometheus metric based response which Kubelet can export. Additionally, a feature gate will be added to only report Prometheus based metrics from the CRI when calling /stats endpoint. The additional metrics we support will need to be added to the individual container runtimes.
The CRI implementation will need to be extended to support reporting the full set of container-level from the [Summary API](#summary-container-stats-object). A new GRPC call will also be added to the CRI that allows reporting for metrics currently exported by cAdvisor, but are outside the scope of the Summary API. This new GRPC call will return a Prometheus metric based response which Kubelet can export. Additionally, PodAndContainerStatsFromCRI feature gate support will be added to only report Prometheus based metrics from the CRI when calling /metrics/cadvisor endpoint when the feature gate is enabled. The additional metrics we support will need to be added to the individual container runtimes.
##### ContainerStats additions
Currently, the CRI endpoints `{,List}ContainerStats` report the following fields for each container:
- CPU
Expand Down Expand Up @@ -478,13 +478,13 @@ rpc ListPodSandboxMetrics(ListPodSandboxMetricsRequest) returns (ListPodSandboxM
message ListPodSandboxMetricsRequest {}
message ListPodSandboxMetricsResponse {
repeated PodSandboxMetrics pod_metrics= 1;
repeated ContainerMetrics container_metrics = 2;
repeated PodSandboxMetrics pod_metrics = 1;
}
message PodSandboxMetrics {
string pod_sandbox_id = 1;
repeated Metric metrics = 2;
repeated ContainerMetrics container_metrics = 3;
}
message ContainerMetrics {
Expand Down

0 comments on commit 4c9ac6d

Please sign in to comment.