Skip to content

Commit

Permalink
KEP 1645: remove EndpointSlice ownership requirement
Browse files Browse the repository at this point in the history
It was discussed at a recent sig meeting that the KEP shoudn't mandate
an MCS EndpointSlice to have an OwnerReference to its ServiceImport as
long as there is any cleanup mechanism in place.

Signed-off-by: Tom Pantelis <[email protected]>
  • Loading branch information
tpantelis committed Oct 3, 2024
1 parent 48f928a commit 23ded99
Showing 1 changed file with 3 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -883,8 +883,9 @@ clusterset, associated with the derived `ServiceImport`. One or more
`EndpointSlice` containing only endpoints from a single source cluster. These
`EndpointSlice` objects will be marked as managed by the clusterset service
controller, so that the endpoint slice controller doesn’t delete them.
`EndpointSlices` will have an owner reference to their associated
`ServiceImport`.
`EndpointSlices` should have an owner reference to their associated
`ServiceImport` unless the implementation has another mechanism to delete
`EndpointSlices` when a service is un-exported.
Since a given `ServiceImport` may be backed by multiple `EndpointSlices`, a
given `EndpointSlice` will reference its `ServiceImport` using the label
Expand Down

0 comments on commit 23ded99

Please sign in to comment.