Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k8s-dns-node-cache doesn't support iptables-nft #338

Closed
champtar opened this issue Jan 3, 2020 · 17 comments · Fixed by #355 or #367
Closed

k8s-dns-node-cache doesn't support iptables-nft #338

champtar opened this issue Jan 3, 2020 · 17 comments · Fixed by #355 or #367

Comments

@champtar
Copy link
Contributor

champtar commented Jan 3, 2020

Right now k8s-dns-node-cache only support iptables-legacy
It would be nice to select iptables-legacy / iptables-nft automatically
see kubernetes/kubernetes#82966 for how kubeproxy does it

@caruccio
Copy link

caruccio commented Mar 4, 2020

@bowei Is it possible to give some attention to this issue? This is a show stopper for centos 8.

@champtar
Copy link
Contributor Author

champtar commented Mar 6, 2020

I rebuilt with

BASEIMAGE?=k8s.gcr.io/debian-iptables-$(ARCH):v12.0.1

And tested on CentOS8 / nft it works fine
Just need to fight with the Makefile a bit and I'll try to send a PR

@caruccio
Copy link

Thanks! It's working now.

@champtar
Copy link
Contributor Author

@caruccio you rebuilt the image yourself ? because I don't see a new release with #355 in it

@caruccio
Copy link

@chadswen I was able to run it with gcr.io/google-containers/kube-proxy:v1.16.9-beta.0

@caruccio
Copy link

@champtar where are you looking at for the builds? Is this a public read-only CI?

@champtar
Copy link
Contributor Author

I was just looking at the tags:
https://github.com/kubernetes/dns/releases

@caruccio
Copy link

OH ... maybe google is building images from master?

@champtar
Copy link
Contributor Author

You are talking about kube-proxy, this is k8s-dns-node-cache*
https://console.cloud.google.com/gcr/images/google-containers/GLOBAL/k8s-dns-node-cache-amd64?gcrImageListsize=30

@caruccio
Copy link

caruccio commented Mar 18, 2020

Even so, this is the same issue in kube-proxy. I will wait for this fix to be release, until then, kube-dns-node-cache is disabled for me. Thanks and sorry for the mess :)

@champtar
Copy link
Contributor Author

For kube-proxy this is fixed in 1.17+

@caruccio
Copy link

For whoever makes the same mistake as I did, the PR for kube-proxy is this kubernetes/kubernetes#82966

@champtar
Copy link
Contributor Author

#355 was reverted, this will be fixed by #367

@justaugustus
Copy link
Member

/reopen
(until #367 merges)

@k8s-ci-robot
Copy link
Contributor

@justaugustus: Reopened this issue.

In response to this:

/reopen
(until #367 merges)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 16, 2020
@bowei
Copy link
Member

bowei commented Aug 16, 2020

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants