Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Traditional Chinese translations in dashboard #5740

Merged
merged 1 commit into from
Dec 24, 2020

Conversation

ydFu
Copy link
Member

@ydFu ydFu commented Dec 23, 2020

  • The transform of 'logs' should be unified at messages.zh-Hant.xlf.(日志 → 日誌)

* The transform of 'logs' should be unified at messages.zh-Hant.xlf.(日志 → 日誌)
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 23, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @ydFu!

It looks like this is your first PR to kubernetes/dashboard 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/dashboard has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/zh Updates or issues for Chinese translations. labels Dec 23, 2020
@codecov
Copy link

codecov bot commented Dec 23, 2020

Codecov Report

Merging #5740 (3e49534) into master (4986a4b) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5740      +/-   ##
==========================================
- Coverage   44.36%   44.35%   -0.02%     
==========================================
  Files         214      214              
  Lines        9126     9126              
  Branches      113      113              
==========================================
- Hits         4049     4048       -1     
- Misses       4803     4804       +1     
  Partials      274      274              

Copy link
Member

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 23, 2020
@ydFu
Copy link
Member Author

ydFu commented Dec 23, 2020

/assign @tanjunchen pls help to review this PR.

Copy link
Member

@tanjunchen tanjunchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chenrui333, tanjunchen, ydFu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 24, 2020
@k8s-ci-robot k8s-ci-robot merged commit 0a0136c into kubernetes:master Dec 24, 2020
@ydFu ydFu deleted the fix-a-typo-in-messages-zh-hant branch December 24, 2020 01:36
@ydFu ydFu changed the title Fix a typo at messages.zh-Hant.xlf. Update Traditional Chinese translations in dashboard Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Updates or issues for Chinese translations. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants