Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sig-cluster-lifecycle: Move CAPOCI to correct location in sig-list #6898

Closed
wants to merge 1 commit into from
Closed

sig-cluster-lifecycle: Move CAPOCI to correct location in sig-list #6898

wants to merge 1 commit into from

Conversation

joekr
Copy link
Member

@joekr joekr commented Sep 28, 2022

Which issue(s) this PR fixes:

No open issues for this

Why this is needed: As part of 63b0c72 CAPOCI office hours were placed in the Cloud Provider section, but should have been in the Cluster Lifecycle section.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 28, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: joekr
Once this PR has been reviewed and has the lgtm label, please assign jdumars for approval by writing /assign @jdumars in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 28, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @joekr. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@joekr joekr changed the title Move CAPOCI to correct location in sig-list sig-cluster-lifecycle: Move CAPOCI to correct location in sig-list Sep 28, 2022
@joekr joekr marked this pull request as ready for review September 28, 2022 14:12
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 28, 2022
neolit123
neolit123 reviewed Sep 28, 2022
View reviewed changes
sigs.yaml
@@ -1165,6 +1154,17 @@ sigs:
url: https://zoom.us/j/91929881559?pwd=WllxazhTUzBFN1BNWTRadTA3NGtQQT09
archive_url: https://docs.google.com/document/d/10aTeq2lhXW_3aFQAd_MdGjY8PtZPslKhZCCcXxFp3_Q/edit
recordings_url: https://www.youtube.com/playlist?list=PL69nYSiGNLP29D0nYgAGWt1ZFqS9Z7lw4
- name: cluster-api-provider-oci
owners:
- https://github.com/oracle/cluster-api-provider-oci/blob/main/OWNERS
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this provider referencing an external repo?
it must be under kubernetes/kubernetes-sigs to be in the sigs.yaml file.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are in the process of donating it kubernetes/org#3404

This change was accepted as part of #6855. This new PR is simply moving it from the Cloud-Provder section into the Cluster-Lifecycle section.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i am surprised this was previously accepted, since TMK a project must first be in our orgs.

cc @jberkus
could you LGTM/approve again?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign @jdumars
hi, could you please help us figuring out if external repositories can be subprojects. afaik, they cannot.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's update this once the project is moved over, I agree with @neolit123 that external repositories should probably not be in this list

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 11, 2022
@joekr
Move CAPOCI to correct location in sig-list
04ecfd8 
As part of 63b0c72 CAPOCI office hours
were placed in the `Cloud Provider` section, but should have been
in the `Cluster Lifecycle` section.
@joekr joekr force-pushed the move-CAPOCI-to-cluster-lifecycle branch from c982db2 to 04ecfd8 Compare October 12, 2022 01:32
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 12, 2022
@joekr joekr requested review from neolit123 and removed request for nckturner and vincepri October 18, 2022 13:33
@joekr
Copy link
Member Author

joekr commented Dec 11, 2022

Will close this for now. Will make a new PR once the repo is donated.

@joekr joekr closed this Dec 11, 2022
@joekr joekr mentioned this pull request Dec 11, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincepri vincepri vincepri left review comments

@neolit123 neolit123 Awaiting requested review from neolit123

Assignees

@jdumars jdumars

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
[SIG ContribEx] Overview
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@joekr @k8s-ci-robot @neolit123 @vincepri @jdumars