-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
corrected path for mentor-guide.md #5427
corrected path for mentor-guide.md #5427
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @dineshkumar181094! |
Hi @dineshkumar181094. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
f6e4acd
to
a482354
Compare
Sorry for the multiple PR, raising the first PR |
/assign @nikhita |
mentoring/programs/the1-on-1hour.md
Outdated
@@ -23,7 +23,7 @@ We will attempt to match you with the closest mentor of your area of interested | |||
|
|||
## Mentors | |||
|
|||
If you are interested in signing up to be a mentor for this, please see the [mentor guidelines](mentor-guide.md). | |||
If you are interested in signing up to be a mentor for this, please see the [mentor guidelines](../processes/mentor-guide.md). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you are interested in signing up to be a mentor for this, please see the [mentor guidelines](../processes/mentor-guide.md). | |
If you are interested in signing up to be a mentor for this, please see the [mentor guidelines](/mentoring/processes/mentor-guide.md). |
Using the full path from the root is preferred. It ensures if the doc is ever moved again the link won't have to be fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, make sense.
Updated the PR accordingly.
e394760
to
0b63da9
Compare
/assign @nikhita |
/ok-to-test |
@nikhita can you merge this PR. |
@dineshkumar181094 were you going to roll in your other PRs into this one? |
Nope |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dineshkumar181094, mrbobbytables The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* fixed filepath * update full path from the root
Which issue(s) this PR fixes:
Fixes #