-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Deflaking tests information to Developer Guide #5205
Add Deflaking tests information to Developer Guide #5205
Conversation
bea62ee
to
b9e0f40
Compare
/approve @liggitt looks good to you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a couple nits, lgtm otherwise
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for doing this. A few suggestions
@kubernetes/ci-signal please review this change. |
This updates flaky-tests.md with all of the information on finding and deflaking tests from the presentation to SIG Testing found here: https://www.youtube.com/watch?v=Ewp8LNY_qTg Also, this drops the outdated "Hunting flaky unit tests" section from flaky-tests.md. Co-authored-by: Aaron Crickenberger <[email protected]>
ef63c8c
to
15de146
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thank you for doing this!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, pymander, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This updates flaky-tests.md with all of the great information from @liggitt's presentation to SIG Testing found here: https://www.youtube.com/watch?v=Ewp8LNY_qTg
Which issue(s) this PR fixes:
Fixes #