Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Deflaking tests information to Developer Guide #5205

Merged

Conversation

pymander
Copy link
Contributor

@pymander pymander commented Oct 8, 2020

This updates flaky-tests.md with all of the great information from @liggitt's presentation to SIG Testing found here: https://www.youtube.com/watch?v=Ewp8LNY_qTg

Which issue(s) this PR fixes:

Fixes #

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/developer-guide Issues or PRs related to the developer guide sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Oct 8, 2020
@pymander pymander force-pushed the devguide/sig-testing-deflaking branch from bea62ee to b9e0f40 Compare October 8, 2020 22:32
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Oct 8, 2020
@dims
Copy link
Member

dims commented Oct 9, 2020

/approve

@liggitt looks good to you?

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2020
Copy link
Member

@liggitt liggitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple nits, lgtm otherwise

Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this. A few suggestions

contributors/devel/sig-testing/flaky-tests.md Outdated Show resolved Hide resolved
contributors/devel/sig-testing/flaky-tests.md Outdated Show resolved Hide resolved
contributors/devel/sig-testing/flaky-tests.md Outdated Show resolved Hide resolved
contributors/devel/sig-testing/flaky-tests.md Outdated Show resolved Hide resolved
contributors/devel/sig-testing/flaky-tests.md Outdated Show resolved Hide resolved
contributors/devel/sig-testing/flaky-tests.md Outdated Show resolved Hide resolved
contributors/devel/sig-testing/flaky-tests.md Outdated Show resolved Hide resolved
@mrbobbytables mrbobbytables added the sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. label Oct 11, 2020
@mrbobbytables mrbobbytables added this to the v1.20 milestone Oct 11, 2020
@RobertKielty
Copy link
Member

@kubernetes/ci-signal please review this change.

This updates flaky-tests.md with all of the information on finding and deflaking tests from the presentation to SIG Testing found here: https://www.youtube.com/watch?v=Ewp8LNY_qTg
Also, this drops the outdated "Hunting flaky unit tests" section from flaky-tests.md.

Co-authored-by: Aaron Crickenberger <[email protected]>
@pymander pymander force-pushed the devguide/sig-testing-deflaking branch from ef63c8c to 15de146 Compare October 21, 2020 16:04
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thank you for doing this!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 21, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, pymander, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 3c61bb0 into kubernetes:master Oct 21, 2020
@pymander pymander deleted the devguide/sig-testing-deflaking branch October 23, 2020 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/developer-guide Issues or PRs related to the developer guide cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants