Add release notes review section #4282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
castrojo
reviewed
Dec 4, 2019
|
/lgtm Just a minor nit, over @jeefy for final review, thanks for your contribution! |
k8s-ci-robot
added
the
lgtm
onlydole
reviewed
Dec 4, 2019
saschagrunert
force-pushed
the
release-notes-review
branch
from
9bb277c to
2f9f234
Compare
k8s-ci-robot
removed
the
lgtm
jeefy
suggested changes
Dec 6, 2019
This adds a dedicated section about the review of release notes. Signed-off-by: Sascha Grunert <[email protected]>
saschagrunert
force-pushed
the
release-notes-review
branch
from
2f9f234 to
a835e35
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: castrojo, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a dedicated section about the review of release notes.
Background information: I have a highly experimental idea of classifying past release notes regarding the three cases described in the change (actually four cases when we assume that the note is correct). I would like to use this data to train a machine learning model which means that the number of classes needs to be as low as possible whereas the accuracy needs to be high. For example, If I classify something as "Has no impact on the user" then someone else should classify it as the same. After the model exists with a fair amount of data, we could use it to classify new release notes and provide some sort of automatism around. To me this seems more useful than providing a dedicated checklist. WDYT?
Refers to #484
/cc @jeefy