Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update registry k8s.gcr.io -> registry.k8s.io #172

Merged
merged 1 commit into from
Mar 3, 2023

Conversation

ArkaSaha30
Copy link
Member

@ArkaSaha30 ArkaSaha30 commented Feb 16, 2023

This PR will update the uses of deprecating k8s.gcr.io registry to registry.k8s.io prior to the planned April freeze.

Tracking Issue: kubernetes/k8s.io#4738
Search results: https://cs.k8s.io/?q=k8s.gcr.io&i=nope&files=&excludeFiles=vendor%2F&repos=kubernetes/committee-security-response

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 16, 2023
@k8s-ci-robot k8s-ci-robot requested a review from enj February 16, 2023 16:13
@k8s-ci-robot k8s-ci-robot added the committee/security-response Denotes an issue or PR intended to be handled by the product security committee. label Feb 16, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 16, 2023
@@ -21,7 +21,7 @@ but you can specifically think of `kube-apiserver` and `kubelet` being the main

- Components built from source in the `kubernetes` github organization and
[all current organizations in use](https://git.k8s.io/community/github-management/README.md#actively-used-github-organizations)
- Container images under the `k8s.gcr.io` repository
- Container images under the `registry.k8s.io` repository
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will support both registries in regards to vulnerabilities. Removing the reference to the old registry is not valid.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @enj , so is it better I add it as a separate line? Or is it not needed at all?

@ArkaSaha30
Copy link
Member Author

Hello @enj , made the change as per you comment. Is this valid or not required at all?
/assign @enj

severity-ratings.md Outdated Show resolved Hide resolved
@enj
Copy link
Member

enj commented Mar 2, 2023

@ArkaSaha30 please rebase and squash into one commit.

@ArkaSaha30 ArkaSaha30 requested a review from enj March 2, 2023 18:58
@ArkaSaha30
Copy link
Member Author

Done @enj 👍

@enj
Copy link
Member

enj commented Mar 3, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 3, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArkaSaha30, enj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2023
@k8s-ci-robot k8s-ci-robot merged commit 0541470 into kubernetes:main Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. committee/security-response Denotes an issue or PR intended to be handled by the product security committee. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants