Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cinder-csi-pugin] Support reconcile volume attachements #976

Merged
merged 2 commits into from
Apr 29, 2020
Merged

[cinder-csi-pugin] Support reconcile volume attachements #976

merged 2 commits into from
Apr 29, 2020

Conversation

takmatsu
Copy link
Contributor

@takmatsu takmatsu commented Mar 17, 2020 •
edited by lingxiankong
Loading

The binaries affected:

  • openstack-cloud-controller-manager
  • cinder-csi-plugin
  • k8s-keystone-auth
  • client-keystone-auth
  • octavia-ingress-controller
  • manila-csi-plugin
  • manila-provisioner
  • magnum-auto-healer
  • barbican-kms-plugin

What this PR does / why we need it:
For supporting VolumeAttachment reconcile, adding capability.
Related: kubernetes-csi/external-attacher#184

Release note:

[cinder-csi-pugin] Support LIST_VOLUMES_PUBLISHED_NODES capability.

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 17, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @takmatsu. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 17, 2020
@theopenlab-ci
Copy link

theopenlab-ci bot commented Mar 17, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Mar 17, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Mar 17, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Mar 17, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Mar 17, 2020

Build succeeded.

@ramineni
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 18, 2020
jichenjc
jichenjc reviewed Mar 18, 2020
View reviewed changes
pkg/csi/cinder/controllerserver.go
@@ -261,6 +261,13 @@ func (cs *controllerServer) ListVolumes(ctx context.Context, req *csi.ListVolume
CapacityBytes: int64(v.Size * 1024 * 1024 * 1024),
},
}

status := &csi.ListVolumesResponse_VolumeStatus{}
for _, attachment := range v.Attachments {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just curious , this attachments means we considered multi attach feature?
one volume attached to multiple node?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also think normally block storage is attached to one node.
But cinder response supports multiple attachments in API level.
https://docs.openstack.org/api-ref/block-storage/v3/index.html?expanded=list-accessible-volumes-with-details-detail#list-accessible-volumes-with-details
and actually some driver may support multi-attach:
https://docs.openstack.org/cinder/latest/admin/blockstorage-volume-multiattach.html

@lingxiankong
Copy link
Contributor

Does this require a minimal version of external-attacher in order to support this capability?

@jichenjc
Copy link
Contributor

jichenjc commented Mar 19, 2020 •
edited
Loading

attacher we are using v2.0.0 now assume the requested feature in 2.1.0 or even higher as kubernetes-csi/external-attacher#184 is in Dec
I have 2 PRs for container update #949 and and #974 , in which #949 updated with non-break thing included update for attacher

@lingxiankong
Copy link
Contributor

@jichenjc so could we hold this one until yours are merged?

@jichenjc
Copy link
Contributor

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 19, 2020
@jichenjc
Copy link
Contributor

@lingxiankong thanks ,did so just now

@takmatsu
Copy link
Contributor Author

@jichenjc it's ok to remove hold now?

@jichenjc
Copy link
Contributor

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 15, 2020
@lingxiankong
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 16, 2020
@ramineni
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ramineni

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 27, 2020
@takmatsu
Copy link
Contributor Author

/test pull-cloud-provider-openstack-test

@ramineni
Copy link
Contributor

@takmatsu pls rebase on latest master

@takmatsu takmatsu force-pushed the support-volume-reconcile branch from 4c518ab to 6dfb9b4 Compare April 27, 2020 11:11
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 27, 2020
@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 27, 2020

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 27, 2020

Build succeeded.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 27, 2020
@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 27, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 27, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 27, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 27, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 27, 2020

Build failed.

@ramineni
Copy link
Contributor

/test cloud-provider-openstack-multinode-csi-migration-test

@k8s-ci-robot
Copy link
Contributor

@ramineni: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-cloud-provider-openstack-check
  • /test pull-cloud-provider-openstack-test

Use /test all to run all jobs.

In response to this:

/test cloud-provider-openstack-multinode-csi-migration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 28, 2020

Build succeeded.

@ramineni
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 29, 2020
@k8s-ci-robot k8s-ci-robot merged commit a687ccc into kubernetes:master Apr 29, 2020
powellchristoph pushed a commit to powellchristoph/cloud-provider-openstack that referenced this pull request Jan 19, 2022
@takmatsu
[cinder-csi-pugin] Support reconcile volume attachements (kubernetes#976
63cf9ca 
)

* Support reconcile volume attachements

* Fix tests for new ListVolumes()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jichenjc jichenjc jichenjc left review comments

@dims dims Awaiting requested review from dims

@FengyunPan2 FengyunPan2 Awaiting requested review from FengyunPan2

Assignees

@lingxiankong lingxiankong

@ramineni ramineni

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@takmatsu @k8s-ci-robot @ramineni @lingxiankong @jichenjc