Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.26.4] 1.26.4 release #2428

Merged
merged 8 commits into from
Oct 19, 2023
Merged

[1.26.4] 1.26.4 release #2428

merged 8 commits into from
Oct 19, 2023

Conversation

kayrus
Copy link
Contributor

@kayrus kayrus commented Oct 12, 2023

What this PR does / why we need it:

This PR bumps a release version for manifests and docs using a new hack/bump-release.sh script

Special notes for reviewers:

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 12, 2023
@kayrus
Copy link
Contributor Author

kayrus commented Oct 12, 2023

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 12, 2023
@kayrus kayrus changed the title [occm] ensure octavia monitor is always updated (#2423) [1.26.4] 1.26.4 release Oct 12, 2023
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 12, 2023
zetaab
zetaab reviewed Oct 12, 2023
View reviewed changes
go.mod
@@ -147,36 +147,3 @@ require (
sigs.k8s.io/structured-merge-diff/v4 v4.2.3 // indirect
sigs.k8s.io/yaml v1.3.0 // indirect
)

replace (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing entire section is little bit scary

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm looking into a solution to avoid this. Replace was a hack when there were dependency issues. Now it should be ok, especially for k8s.io deps. I'd like to play a bit with these dependencies before continuing.

@kayrus kayrus force-pushed the r126 branch 3 times, most recently from 0784a84 to c44ee46 Compare October 12, 2023 19:47
@dulek
Copy link
Contributor

dulek commented Oct 13, 2023

Can we squash the commit doing the revert of the k3s version?

@dulek
Copy link
Contributor

dulek commented Oct 13, 2023

/test openstack-cloud-controller-manager-e2e-test

Looks like k3s update breaks CI?

@k8s-ci-robot
Copy link
Contributor

@dulek: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test openstack-cloud-controller-manager-e2e-test-release-126
  • /test openstack-cloud-csi-cinder-e2e-test-release-126
  • /test openstack-cloud-csi-cinder-sanity-test-release-126
  • /test openstack-cloud-csi-manila-e2e-test-release-126
  • /test openstack-cloud-csi-manila-sanity-test-release-126
  • /test pull-cloud-provider-openstack-check
  • /test pull-cloud-provider-openstack-test

Use /test all to run the following jobs that were automatically triggered:

  • openstack-cloud-csi-cinder-e2e-test-release-126
  • pull-cloud-provider-openstack-check
  • pull-cloud-provider-openstack-test

In response to this:

/test openstack-cloud-controller-manager-e2e-test

Looks like k3s update breaks CI?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dulek
Copy link
Contributor

dulek commented Oct 13, 2023

/test openstack-cloud-controller-manager-e2e-test-release-126

@kayrus
.: bump golang.org/x/net to v0.17.0
7c7a056 
Bumping golang.org/x/net in light of CVE-2023-39325 and CVE-2023-44487.
@kayrus
Copy link
Contributor Author

kayrus commented Oct 19, 2023

/test ?

@k8s-ci-robot
Copy link
Contributor

@kayrus: The following commands are available to trigger required jobs:

  • /test openstack-cloud-controller-manager-e2e-test-release-126
  • /test openstack-cloud-csi-cinder-e2e-test-release-126
  • /test openstack-cloud-csi-cinder-sanity-test-release-126
  • /test openstack-cloud-csi-manila-e2e-test-release-126
  • /test openstack-cloud-csi-manila-sanity-test-release-126
  • /test pull-cloud-provider-openstack-check
  • /test pull-cloud-provider-openstack-test

Use /test all to run the following jobs that were automatically triggered:

  • openstack-cloud-csi-cinder-e2e-test-release-126
  • pull-cloud-provider-openstack-check
  • pull-cloud-provider-openstack-test

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kayrus
Copy link
Contributor Author

kayrus commented Oct 19, 2023

/test openstack-cloud-controller-manager-e2e-test-release-126
/test openstack-cloud-csi-cinder-e2e-test-release-126
/test openstack-cloud-csi-cinder-sanity-test-release-126
/test openstack-cloud-csi-manila-e2e-test-release-126
/test openstack-cloud-csi-manila-sanity-test-release-126
/test pull-cloud-provider-openstack-check
/test pull-cloud-provider-openstack-test

zetaab and others added 3 commits October 19, 2023 15:21
@zetaab @kayrus
Update k3s and test image to ubuntu 22 (kubernetes#2108)
b68ad5a 
* use ubuntu focal

* update k3s used in tests

* update default version
@stephenfin @kayrus
tests: Remove support for preinstalled images
75b96b2 
This never worked and the image in question is no longer available.

Signed-off-by: Stephen Finucane <[email protected]>
@kayrus
Fix tests
d54c810
@kayrus
Copy link
Contributor Author

kayrus commented Oct 19, 2023

/test openstack-cloud-controller-manager-e2e-test-release-126
/test openstack-cloud-csi-cinder-sanity-test-release-126
/test openstack-cloud-csi-manila-e2e-test-release-126
/test openstack-cloud-csi-manila-sanity-test-release-126

@stmcginnis @kayrus
Use dl.k8s.io instead of hardcoded GCS URIs (kubernetes#2240)
fe6753d 
The `storage.googleapis.com/kubernetes-release` URL is a hard coded path
to a GCS bucket location. To allow redirecting and spreading the load
across multiple hosting locations, the `dl.k8s.io` URL has been
introduced.

Signed-off-by: Sean McGinnis <[email protected]>
@kayrus
Copy link
Contributor Author

kayrus commented Oct 19, 2023

/test openstack-cloud-controller-manager-e2e-test-release-126
/test openstack-cloud-csi-cinder-e2e-test-release-126
/test openstack-cloud-csi-cinder-sanity-test-release-126
/test openstack-cloud-csi-manila-e2e-test-release-126
/test openstack-cloud-csi-manila-sanity-test-release-126
/test pull-cloud-provider-openstack-check
/test pull-cloud-provider-openstack-test

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 19, 2023
@kayrus
Copy link
Contributor Author

kayrus commented Oct 19, 2023

/test openstack-cloud-controller-manager-e2e-test-release-126
/test openstack-cloud-csi-cinder-e2e-test-release-126
/test openstack-cloud-csi-cinder-sanity-test-release-126
/test openstack-cloud-csi-manila-e2e-test-release-126
/test openstack-cloud-csi-manila-sanity-test-release-126
/test pull-cloud-provider-openstack-check
/test pull-cloud-provider-openstack-test

@kayrus
Copy link
Contributor Author

kayrus commented Oct 19, 2023

/test openstack-cloud-controller-manager-e2e-test-release-126

@zetaab
Copy link
Member

zetaab commented Oct 19, 2023

/approve
/lgtm

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 19, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 19, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zetaab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2023
@k8s-ci-robot k8s-ci-robot merged commit 56feeb1 into kubernetes:release-1.26 Oct 19, 2023
1 check passed
@kayrus kayrus deleted the r126 branch October 19, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zetaab zetaab zetaab left review comments

@dulek dulek Awaiting requested review from dulek

@mdbooth mdbooth Awaiting requested review from mdbooth

@jichenjc jichenjc Awaiting requested review from jichenjc

Assignees

@zetaab zetaab

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kayrus @dulek @k8s-ci-robot @zetaab @stephenfin @stmcginnis