[occm] Remove filtering by device_owner.

[gryf]

In OpenStack default AZ is called 'nova', thus device_owner is filled with 'compute:nova', and that's ok for deployments within one (default) AZ.

Filtering by device_owner however, will make function getAttachedPorts to return zero ports for provided node. In this patch, filtering by device_owner is simply removed.

What this PR does / why we need it:

Which issue this PR fixes(if applicable):
fixes #2303

Special notes for reviewers:

Release note:

NONE

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: gryf / name: Roman Dobosz (c917e1e)

[k8s-ci-robot]

Welcome @gryf!

It looks like this is your first PR to kubernetes/cloud-provider-openstack 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/cloud-provider-openstack has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @gryf. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dulek]

/ok-to-test

[zetaab]

interesting, we do have multiple AZs (any of them are not called nova) and we are not facing issues

[zetaab]

Anyways the query against openstack api should be still quite fast. I do not see reason to not remove this.

/approve

@dulek opinions?

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zetaab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/openstack/OWNERS [zetaab]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[gryf]

@zetaab this issue manifests itself after transitions from nova os-interfaces to neutron calls - if you on 1.27, you'll not see this.

[dulek]

Anyways the query against openstack api should be still quite fast. I do not see reason to not remove this.

It was caused by #2250, we've just discovered this today when trying master on a cloud that has AZs.

The main reason I insisted to include this in the query was to foresee a situation when Nova isn't the only consumer of Neutron and we could have device_id populated with the server ID, but with different device_owner. Currently Nova's code will break such a use case anyway, as they don't check device_owner at all. It's safe to remove this, it was just me trying to make it too perfect. ;)

[dulek]

/lgtm

[dulek]

@mdbooth FYI