[all] Update k8s dependencies to v1.19.0 #1151

seanschneeweiss · 2020-08-06T15:52:36Z

What this PR does / why we need it:
The current v1.18.0 service controller for OCCM is missing two important fixes:

Also the cloud-provider controllers were moved to k8s.io/cloud-provider/controllers.

Therefore, an update/vendoring is suggested to version v1.19.0.

Which issue this PR fixes(if applicable):
fixes #

Special notes for reviewers:

Release note:

NONE

_{Sean Schneeweiss [email protected], Daimler TSS GmbH, legal info/Impressum}

k8s-ci-robot · 2020-08-06T15:52:44Z

Hi @seanschneeweiss. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

theopenlab-ci · 2020-08-06T15:56:17Z

Build failed.

cloud-provider-openstack-format : FAILURE in 3m 08s

theopenlab-ci · 2020-08-06T15:56:41Z

Build failed.

cloud-provider-openstack-unittest : FAILURE in 3m 27s

theopenlab-ci · 2020-08-06T15:56:43Z

Build succeeded.

cloud-provider-openstack-sanity-test-csi-cinder : SUCCESS in 2m 54s

theopenlab-ci · 2020-08-06T16:00:37Z

Build failed.

cloud-provider-openstack-acceptance-test-lb-octavia : FAILURE in 6m 52s

theopenlab-ci · 2020-08-06T16:02:10Z

Build failed.

cloud-provider-openstack-acceptance-test-csi-cinder : POST_FAILURE in 8m 16s

theopenlab-ci · 2020-08-06T16:03:18Z

Build failed.

cloud-provider-openstack-e2e-test-csi-cinder : POST_FAILURE in 8m 54s

theopenlab-ci · 2020-08-06T16:13:54Z

Build failed.

cloud-provider-openstack-format : FAILURE in 2m 21s

theopenlab-ci · 2020-08-06T16:14:49Z

Build failed.

cloud-provider-openstack-unittest : FAILURE in 3m 33s

theopenlab-ci · 2020-08-06T16:15:31Z

Build succeeded.

cloud-provider-openstack-sanity-test-csi-cinder : SUCCESS in 2m 48s

theopenlab-ci · 2020-08-06T16:25:28Z

Build failed.

cloud-provider-openstack-e2e-test-csi-cinder : POST_FAILURE in 11m 32s

theopenlab-ci · 2020-08-06T16:27:48Z

Build failed.

cloud-provider-openstack-acceptance-test-lb-octavia : FAILURE in 9m 43s

theopenlab-ci · 2020-08-06T16:30:42Z

Build failed.

cloud-provider-openstack-acceptance-test-csi-cinder : POST_FAILURE in 17m 39s

theopenlab-ci · 2020-08-06T16:36:17Z

Build failed.

cloud-provider-openstack-acceptance-test-keystone-authentication-authorization : FAILURE in 23m 53s

theopenlab-ci · 2020-08-06T16:40:26Z

Build failed.

cloud-provider-openstack-acceptance-test-e2e-conformance : POST_FAILURE in 8m 33s

theopenlab-ci · 2020-08-06T17:01:12Z

Build succeeded.

cloud-provider-openstack-multinode-csi-migration-test : SUCCESS in 43m 02s

theopenlab-ci · 2020-08-06T17:26:48Z

Build succeeded.

cloud-provider-openstack-acceptance-test-csi-manila : SUCCESS in 56m 32s

theopenlab-ci · 2020-08-06T20:27:33Z

Build succeeded.

cloud-provider-openstack-sanity-test-csi-cinder : SUCCESS in 3m 01s

theopenlab-ci · 2020-08-06T20:27:43Z

Build succeeded.

cloud-provider-openstack-unittest : SUCCESS in 3m 38s

ramineni · 2020-09-08T06:49:28Z

/test cloud-provider-openstack-acceptance-test-csi-manila

k8s-ci-robot · 2020-09-08T06:49:29Z

@ramineni: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

/test pull-cloud-provider-openstack-check
/test pull-cloud-provider-openstack-test

Use /test all to run all jobs.

In response to this:

/test cloud-provider-openstack-acceptance-test-csi-manila

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

theopenlab-ci · 2020-09-08T09:21:23Z

Build failed.

cloud-provider-openstack-acceptance-test-csi-manila : POST_FAILURE in 2h 29m 35s

lingxiankong · 2020-09-08T10:39:51Z

@gman0 @gouthampacha @tombarron Could you please help to look at the failure of the job cloud-provider-openstack-acceptance-test-csi-manila?

2020-09-08 07:44:38.188857 | ubuntu-bionic | + /home/zuul/src/k8s.io/kubernetes/cluster/kubectl.sh wait --for=condition=Ready pod/new-nfs-share-snap-restore-pod --timeout=300s
2020-09-08 07:49:39.110059 | ubuntu-bionic | error: timed out waiting for the condition on pods/new-nfs-share-snap-restore-pod

gman0 · 2020-09-08T11:26:44Z

@lingxiankong I'll have a look.

csi-snapshotter logs:

E0908 07:43:44.636902       1 snapshot_controller.go:370] createSnapshot [create-default/new-nfs-share-snap[81b4c0af-5cb3-40c8-8d9b-1952f4fc51a2]]: error occurred in createSnapshotOperation: selfLink was empty, can't make reference

The snapshot is never created. This in turn fails to create a PVC from this snapshot. pods/new-nfs-share-snap-restore-pod mounts this PVC, but can't.

gman0 · 2020-09-08T11:29:19Z

@ramineni and other csi-cinder folks: can you please confirm snapshotting works for you with k8s 1.19 and csi-snapshotter v1.2.2?

jichenjc · 2020-09-08T11:32:42Z

I tested locally #974 before the code merge (volume create ==> snapshot create ) , it is not v1.19 exactly but it's with master branch , of course not with very thorough test due to no CI

why cinder CSI snapshot is related to manila ?

gman0 · 2020-09-08T11:37:28Z

@jichenjc Ah, I missed #974. Both CSI Cinder and Manila were on csi-snapshotter v1.2.2 (or at least the csi-cinder's Helm chart still is). And CI job for csi-manila tests snapshotting as well.

jichenjc · 2020-09-08T11:43:07Z

@jichenjc Ah, I missed #974. Both CSI Cinder and Manila were on csi-snapshotter v1.2.2 (or at least the csi-cinder's Helm chart still is). And CI job for csi-manila tests snapshotting as well.

should I do additional test? I don't have manila env on my hand ..

ramineni · 2020-09-09T04:41:45Z

@ramineni and other csi-cinder folks: can you please confirm snapshotting works for you with k8s 1.19 and csi-snapshotter v1.2.2?

@gman0 cinder is updated to 2.1.1 for 1.19 .
Any update on the manila failure? This is blocking cpo release.
/cc @gouthampacha @tombarron

gman0 · 2020-09-09T15:58:21Z

@ramineni OpenLab's install-k8s role uses k8s master:

2020-09-08 06:54:30.295331 | TASK [install-k8s : Install etcd v3.4.13 and kubernetes master]

I've just checked out k8s with branch v1.19.0 and csi-snapshotter v1.2.2 works. Then I tried with k8s master:

E0909 15:43:35.798659       1 event.go:247] Could not construct reference to: '&v1alpha1.VolumeSnapshot{TypeMeta:v1.TypeMeta{Kind:"", APIVersion:""}, ObjectMeta:v1.ObjectMeta{Name:"new-nfs-share-snap", GenerateName:"", Namespace:"default", SelfLink:"", UID:"c06ae5a9-7a84-441a-8fe2-b2b3eea805b0", ResourceVersion:"470", Generation:2, CreationTimestamp:v1.Time{Time:time.Time{wall:0x0, ext:63735262998, loc:(*time.Location)(0x238f460)}}, DeletionTimestamp:(*v1.Time)(nil), DeletionGracePeriodSeconds:(*int64)(nil), Labels:map[string]string(nil), Annotations:map[string]string(nil), OwnerReferences:[]v1.OwnerReference(nil), Initializers:(*v1.Initializers)(nil), Finalizers:[]string{"snapshot.storage.kubernetes.io/volumesnapshot-protection"}, ClusterName:"", ManagedFields:[]v1.ManagedFieldsEntry{v1.ManagedFieldsEntry{Manager:"kubectl", Operation:"Update", APIVersion:"snapshot.storage.k8s.io/v1alpha1", Time:(*v1.Time)(0xc000319bc0), Fields:(*v1.Fields)(nil)}, v1.ManagedFieldsEntry{Manager:"csi-snapshotter", Operation:"Update", APIVersion:"snapshot.storage.k8s.io/v1alpha1", Time:(*v1.Time)(0xc000319c20), Fields:(*v1.Fields)(nil)}}}, Spec:v1alpha1.VolumeSnapshotSpec{Source:(*v1.TypedLocalObjectReference)(0xc0002f16e0), SnapshotContentName:"", VolumeSnapshotClassName:(*string)(0xc000698610)}, Status:v1alpha1.VolumeSnapshotStatus{CreationTime:(*v1.Time)(0xc000319c40), RestoreSize:(*resource.Quantity)(0xc000649dc0), ReadyToUse:false, Error:(*v1beta1.VolumeError)(0xc0002f1710)}}' due to: 'selfLink was empty, can't make reference'. Will not report event: 'Warning' 'SnapshotCreationFailed' 'Failed to create snapshot: selfLink was empty, can't make reference'
E0909 15:43:35.798716       1 snapshot_controller.go:370] createSnapshot [create-default/new-nfs-share-snap[c06ae5a9-7a84-441a-8fe2-b2b3eea805b0]]: error occurred in createSnapshotOperation: selfLink was empty, can't make reference

...which is the same error as we're getting from the CI. I suspect this might be a bug in the latest Kubernetes.

gman0 · 2020-09-09T16:01:29Z

To not block this PR any further, I'll disable all snapshot-related tests in csi-manila's CI job until it's resolved (or we move to csi-snapshotter v2 - whichever comes first).

tombarron · 2020-09-09T16:12:49Z

Thankis for this out, @gman0. I had a long weekend (holiday combined with a couple days vacation) and was just looking at this issue now and was not sure what was going on.

lingxiankong · 2020-09-10T01:25:23Z

/test cloud-provider-openstack-acceptance-test-csi-manila

k8s-ci-robot · 2020-09-10T01:25:24Z

@lingxiankong: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

/test pull-cloud-provider-openstack-check
/test pull-cloud-provider-openstack-test

Use /test all to run all jobs.

In response to this:

/test cloud-provider-openstack-acceptance-test-csi-manila

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

theopenlab-ci · 2020-09-10T02:20:08Z

Build succeeded.

cloud-provider-openstack-acceptance-test-csi-manila : SUCCESS in 52m 30s

jichenjc · 2020-09-10T02:26:01Z

/approve
I think we are ready to merge this now

k8s-ci-robot · 2020-09-10T02:26:18Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jichenjc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [jichenjc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

lingxiankong · 2020-09-10T04:49:38Z

@jichenjc @ramineni @wangxiyuan @gman0 thanks for your help!

* [occm] update cloud-provider to 1.19.0 This commit updates k8s version to 1.19.0 to use the cloud-provider pkg from its new location. Signed-off-by: Sean Schneeweiss <[email protected]> * [occm] use version v1.19.0, do not use InstancesV2 InstancesV2 requires further testing before being used. Signed-off-by: Sean Schneeweiss <[email protected]>

k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 6, 2020

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 6, 2020

k8s-ci-robot requested review from FengyunPan2 and lingxiankong August 6, 2020 15:52

seanschneeweiss changed the title ~~[occm] Update k8s dependencies to v1.19.0-rc.4~~ [all] Update k8s dependencies to v1.19.0-rc.4 Aug 6, 2020

seanschneeweiss changed the title ~~[all] Update k8s dependencies to v1.19.0-rc.4~~ [WIP] [all] Update k8s dependencies to v1.19.0-rc.4 Aug 6, 2020

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 6, 2020

seanschneeweiss changed the title ~~[WIP] [all] Update k8s dependencies to v1.19.0-rc.4~~ [WIP] [all] Update k8s dependencies to v1.19.0-rc.2 Aug 6, 2020

seanschneeweiss force-pushed the update-cloud-provider-module branch from c5151d9 to 7440729 Compare August 6, 2020 20:23

k8s-ci-robot requested review from gouthampacha and tombarron September 9, 2020 04:41

This was referenced Sep 9, 2020

manila-csi-plugin: temporarily disable snapshot tests theopenlab/openlab-zuul-jobs#1020

Merged

csi-snapshotter v1: "selfLink was empty, can't make reference" kubernetes/kubernetes#94660

Closed

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2020

k8s-ci-robot merged commit cbee1e1 into kubernetes:master Sep 10, 2020

k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Sep 10, 2020

This was referenced May 18, 2021

REQUEST: New membership for seanschneeweiss kubernetes/org#2719

Closed

REQUEST: New membership for seanschneeweiss kubernetes/org#2725

Closed

[all] Update k8s dependencies to v1.19.0 #1151

[all] Update k8s dependencies to v1.19.0 #1151

Conversation

seanschneeweiss commented Aug 6, 2020 • edited by lingxiankong Loading

k8s-ci-robot commented Aug 6, 2020

theopenlab-ci bot commented Aug 6, 2020

theopenlab-ci bot commented Aug 6, 2020

theopenlab-ci bot commented Aug 6, 2020

theopenlab-ci bot commented Aug 6, 2020

theopenlab-ci bot commented Aug 6, 2020

theopenlab-ci bot commented Aug 6, 2020

theopenlab-ci bot commented Aug 6, 2020

theopenlab-ci bot commented Aug 6, 2020

theopenlab-ci bot commented Aug 6, 2020

theopenlab-ci bot commented Aug 6, 2020

theopenlab-ci bot commented Aug 6, 2020

theopenlab-ci bot commented Aug 6, 2020

theopenlab-ci bot commented Aug 6, 2020

theopenlab-ci bot commented Aug 6, 2020

theopenlab-ci bot commented Aug 6, 2020

theopenlab-ci bot commented Aug 6, 2020

theopenlab-ci bot commented Aug 6, 2020

theopenlab-ci bot commented Aug 6, 2020

ramineni commented Sep 8, 2020

k8s-ci-robot commented Sep 8, 2020

theopenlab-ci bot commented Sep 8, 2020

lingxiankong commented Sep 8, 2020 • edited Loading

gman0 commented Sep 8, 2020

gman0 commented Sep 8, 2020

jichenjc commented Sep 8, 2020 • edited Loading

gman0 commented Sep 8, 2020 • edited Loading

jichenjc commented Sep 8, 2020

ramineni commented Sep 9, 2020

gman0 commented Sep 9, 2020

gman0 commented Sep 9, 2020

tombarron commented Sep 9, 2020

lingxiankong commented Sep 10, 2020

k8s-ci-robot commented Sep 10, 2020

theopenlab-ci bot commented Sep 10, 2020

jichenjc commented Sep 10, 2020

k8s-ci-robot commented Sep 10, 2020

lingxiankong commented Sep 10, 2020

seanschneeweiss commented Aug 6, 2020 •

edited by lingxiankong

Loading

lingxiankong commented Sep 8, 2020 •

edited

Loading

jichenjc commented Sep 8, 2020 •

edited

Loading

gman0 commented Sep 8, 2020 •

edited

Loading