Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[occm] Address detection logic fixes #1044

Closed
wants to merge 1 commit into from
Closed

[occm] Address detection logic fixes #1044

wants to merge 1 commit into from

Conversation

zuzzas
Copy link
Contributor

@zuzzas zuzzas commented Apr 23, 2020

What this PR does / why we need it:
If the internal-network-name option is present, ignore FixedIPs from other networks.

Which issue this PR fixes(if applicable):
fixes #1039

Special notes for reviewers:
Cherry-pick candidate for branch release-1.18

Similar to #1041, but is a tiny bit harder on the OpenStack API. Also fixes FixedIPs being added that are not specified in the config.

Release note:

NONE

@zuzzas
[occm] Address detection logic fixes
07e8ad8 
Signed-off-by: Andrey Klimentyev <[email protected]>
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 23, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @zuzzas. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign fengyunpan2
You can assign the PR to them by writing /assign @fengyunpan2 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 23, 2020
@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 23, 2020

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 23, 2020

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 23, 2020

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 23, 2020

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 23, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 23, 2020

Build failed.

@zuzzas
Copy link
Contributor Author

zuzzas commented Apr 23, 2020

#1041 provides a proper implementation right now.

@zuzzas zuzzas closed this Apr 23, 2020
@zuzzas zuzzas deleted the fixedIP-detection-change branch May 18, 2021 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anguslees anguslees Awaiting requested review from anguslees

@FengyunPan2 FengyunPan2 Awaiting requested review from FengyunPan2

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[occm] 'internal-network-name' broken since release 1.18
2 participants
@zuzzas @k8s-ci-robot