-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump K8s libs to 0.25.3 #522
Conversation
@lobziik: This issue is currently awaiting triage. If cloud-provider-aws contributors determine this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @lobziik. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/retest |
Doesn't look like the version bumps pass tests just like that, unfortunately. It errors out in a panic. |
/cc @nckturner |
@olemarkus I rolled back bump for e2e suite, I suggest to address dependency bump for e2e suite in follow-up PR, this shouldn't affect this test essence i think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought we already bumped to ginkgo v2. I've seen this error before when one used mixed versions though. We'll have a look in a followup PR.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: olemarkus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/kind bug
/kind cleanup
What this PR does / why we need it:
Bug described in kubernetes/kubernetes#112793 was introduced in released versions of
k8s.io/cloud-provider
, namely in v0.25.(0, 1, 2). This was fixed in the most recentk8s.io/cloud-provider
versionv0.25.3
. This PR bumps k8s libs to bring this fix into cloud-provider-aws.Also, this patch bumps k8s libs version for the e2e test suite.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: