Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPA: Implement in-place updates support #7673

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

VPA: Implement in-place updates support #7673

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
8a59ac9
VPA: Add UpdateModeInPlaceOrRecreate to types
jkyros Mar 14, 2024
cdfb9cb
VPA: Allow admission-controller to validate in-place spec
maxcao13 Jan 7, 2025
fd3a131
VPA: Stuck in-place resizes still require eviction
jkyros Mar 14, 2024
6284342
VPA: Make eviction restriction in-place aware
jkyros Mar 14, 2024
52707fa
VPA: Updater logic allows in-place scaling
jkyros Mar 14, 2024
db80f5c
VPA: Add metrics gauges for in-place updates
jkyros Mar 14, 2024
ba33da7
VPA: Update mocks to accommodate in-place VPA changes
jkyros Mar 14, 2024
0906e7f
VPA: hack unit tests to account for in-place
jkyros Mar 14, 2024
be55470
VPA: Add e2e tests for in-place scaling
jkyros Mar 23, 2024
fb55076
VPA: allow rule-breaking updates if disruptionless
jkyros Mar 23, 2024
5172a17
only allow in-place if explicitly set (for testing)
jkyros Mar 21, 2024
37dc76f
VPA: Allow VPA updater to actuate recommendations in-place
maxcao13 Dec 20, 2024
45d0954
VPA: Enable InPlacePodVerticalScaling feature flag on e2e
maxcao13 Jan 7, 2025
4211102
VPA: Add in-place actuation and admission-controller e2e tests
maxcao13 Jan 7, 2025
e739fd9
VPA: fix logs and cleanup TODOs according to review
maxcao13 Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions vertical-pod-autoscaler/deploy/vpa-rbac.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,32 @@ rules:
- create
---
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
name: system:vpa-updater-in-place
rules:
- apiGroups:
- ""
resources:
- pods/resize
- pods
verbs:
- patch
---
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
name: system:vpa-updater-in-place-binding
roleRef:
apiGroup: rbac.authorization.k8s.io
kind: ClusterRole
name: system:vpa-updater-in-place
subjects:
- kind: ServiceAccount
name: vpa-updater
namespace: kube-system
---
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
name: system:metrics-reader
Expand Down
1 change: 1 addition & 0 deletions vertical-pod-autoscaler/deploy/vpa-v1-crd-gen.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -458,6 +458,7 @@ spec:
- "Off"
- Initial
- Recreate
- InPlaceOrRecreate
- Auto
type: string
type: object
Expand Down
Loading
Loading