VPA: Add the api-approved.kubernetes.io annotation via kubebuilder tag

[ialidzhikov]

What type of PR is this?

/kind feature

What this PR does / why we need it:

CRDs using the *.k8s.io group require the api-approved.kubernetes.io annotation to be present on the CRD.

Previously, it was not possible to provide this annotation with kubebuilder (see kubernetes-sigs/controller-tools#656), that's why we have a workaround logic on VPA CRD generation to add this annotation via kustomize:

autoscaler/vertical-pod-autoscaler/hack/generate-crd-yaml.sh

Lines 47 to 56 in 95ec5f3

	cd ${WORKSPACE}
	cat <<EOF > kustomization.yaml
	resources:
	- autoscaling.k8s.io_verticalpodautoscalers.yaml
	- autoscaling.k8s.io_verticalpodautoscalercheckpoints.yaml
	commonAnnotations:
	"api-approved.kubernetes.io": "https://github.com/kubernetes/kubernetes/pull/63797"
	EOF
	echo --- > ${OUTPUT}
	kubectl kustomize . >> ${OUTPUT}

This PR:

• Updates sigs.k8s.io/controller-tools/cmd/controller-gen from v0.9.2 to v0.16.5. I decided to update because using go1.22 with controller-gen < 0.14 panics - see [controller-gen] invalid memory address or nil pointer dereference [recovered] kubernetes-sigs/controller-tools#888 (comment)
• Adds the api-approved.kubernetes.io annotation to the CRDs using the kubebuilder tag.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

PR can be reviewed following the dedicated commits.

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[k8s-ci-robot]

@ialidzhikov: The label(s) kind/enhancement cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind enhancement

What this PR does / why we need it:

CRDs from k8s.io require the api-approved.kubernetes.io annotation.
Previously, it was not possible to provide this annotation with kubebuilder (see kubernetes-sigs/controller-tools#656), that's why we have a workaround logic on VPA CRD generation to add this annotation via kustomize:

autoscaler/vertical-pod-autoscaler/hack/generate-crd-yaml.sh

Lines 47 to 56 in 95ec5f3

	cd ${WORKSPACE}
	cat <<EOF > kustomization.yaml
	resources:
	- autoscaling.k8s.io_verticalpodautoscalers.yaml
	- autoscaling.k8s.io_verticalpodautoscalercheckpoints.yaml
	commonAnnotations:
	"api-approved.kubernetes.io": "https://github.com/kubernetes/kubernetes/pull/63797"
	EOF
	echo --- > ${OUTPUT}
	kubectl kustomize . >> ${OUTPUT}

This PR:

• Updates sigs.k8s.io/controller-tools/cmd/controller-gen from v0.9.2 to v0.16.5. I decided to update because using go1.22 with controller-gen < 0.14 panics - see [controller-gen] invalid memory address or nil pointer dereference [recovered] kubernetes-sigs/controller-tools#888 (comment)
• Adds the api-approved.kubernetes.io annotation to the CRDs using the kubebuilder tag.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

PR can be reviewed following the dedicated commits.

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ialidzhikov]

/kind feature

[adrianmoisey]

/lgtm

Thanks for handling this

/remove-kind feature
/kind cleanup

(Just making it a cleanup, since this isn't related to a new VPA feature)

[raywainman]

Thanks for the cleanup!

/lgtm

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ialidzhikov, raywainman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• vertical-pod-autoscaler/OWNERS [raywainman]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment