Add golangci-lint to github workflow

[omerap12]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Adds golangci-lint to verify code quality along with golint (ref: #7542 (comment))

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: omerap12
Once this PR has been reviewed and has the lgtm label, please assign gjtempleton for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[omerap12]

I've added this action: golangci-lint-action v6. However, I’m not happy with the duplicated code—perhaps someone can suggest a better approach.

One possibility is to create a separate GitHub workflow file to run the linter in parallel using a matrix configuration.
example:

lint:
  runs-on: ubuntu-latest
  strategy:
    matrix:
      dir: [vertical-pod-autoscaler, cluster-autoscaler, addon-resizer, balancer, multidimensional-pod-autoscaler]
  steps:
    - name: Set up Go
      uses: actions/setup-go@v2
      with:
        go-version: '1.22.2'

    - uses: actions/checkout@v2
      with:
        path: ${{ env.GOPATH }}/src/k8s.io/autoscaler

    - name: golangci-lint
      uses: golangci/golangci-lint-action@v6
      with:
        working-directory: ${{ env.GOPATH }}/src/k8s.io/autoscaler/${{ matrix.dir }}
        version: v1.60

Alternatively, we could skip GitHub Actions entirely and integrate this manually into the existing script: verify-golint.sh.

Any thoughts or suggestions?
cc @adrianmoisey @voelzmo

[raywainman]

FWIW I think the way you have it here is OK.

Moving these up into GitHub Actions seems like the right path forward to me, the UX is also slightly better that way with a nice breakdown in each PR for each action.

So overall direction here LGTM.

[adrianmoisey]

I'm also fine with the duplication, it isn't that big of a deal

[adrianmoisey]

Could you enable checks? I want to see what the annotations look like: https://github.com/golangci/golangci-lint-action?tab=readme-ov-file#annotations

[omerap12]

I have changed this just for testing purposes . Ill will revert this before merge

[omerap12]

Could you enable checks? I want to see what the annotations look like: https://github.com/golangci/golangci-lint-action?tab=readme-ov-file#annotations

done

[adrianmoisey]

I tested out annotations in https://github.com/kubernetes/autoscaler/pull/7558/files, I like them

[adrianmoisey]

Hmmm... balancer is failing.
May be this needs to be rolled out project at a time?

[omerap12]

@adrianmoisey , added.
I will raise another PR to fix all those golang-lint fixes.

[omerap12]

Hmmm... balancer is failing. May be this needs to be rolled out project at a time?

Hmmm... balancer is failing. May be this needs to be rolled out project at a time?

GitHub Actions PRs can be hard to merge, so I tried to do everything in one PR. I don’t mind splitting it into a couple of PRs if that works better. @raywainman, what do you think?

[adrianmoisey]

I don’t mind splitting it into a couple of PRs if that works better.

For approval sake, it may make sense to make a PR per project, and once they are merged, add the GitHub Action

[omerap12]

So I'm closing this PR for now