Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all VPA docs into ./docs #7548

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

adrianmoisey
Copy link
Member

@adrianmoisey adrianmoisey commented Dec 1, 2024

/kind documentation

This PR is a replacement for #7532 and the discussion that happened after it.

sig-docs discussion
sig-autoscaling discussion

The tl;dr is that this PR is decoupling the docs from the code layout, with the hopes that it allows us to more easily write documentation. Having something that is more easily navigable may help us find the right place to put the documentation.

Note: there are a few bits and pieces that I'm not happy with right now, like the features page. My plan is to get this merged first, and follow up with more PRs to tidy up.

After this PR has been merged, my hope is that some more documentation is written (based on new features, or to clarify common support issues that we get).

Then sometime in the future, we can decide if it makes sense to go with a standalone website, or move to k/website.

This is to try make the docs decoupled from the code, hoping that this
will allow for easier restructuring of the docs, and also lead to
improved docs over time.
@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. area/vertical-pod-autoscaler labels Dec 1, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 1, 2024
Copy link
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, now that i'm looking at the correct PR, this looks much better lol.

i think this makes sense to me and i'm happy to see the readme updated.

copied from my comment on the other pr

also, i was thinking about how we might want to document the cluster-autoscaler stuff and i think it will be challenging to solve this problem due to the providers. i think it's possible we could migrate the core CA docs, but we would want to have links for the provider specific pieces since those docs are owned by the various providers.

@omerap12
Copy link
Member

omerap12 commented Dec 4, 2024

Amazing!

@voelzmo
Copy link
Contributor

voelzmo commented Dec 4, 2024

/approve

great work, thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrianmoisey, voelzmo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2024
@omerap12
Copy link
Member

omerap12 commented Dec 4, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 4, 2024
@k8s-ci-robot k8s-ci-robot merged commit b5b760f into kubernetes:master Dec 4, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/vertical-pod-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants