Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates Golang version to 1.23 #7311

Conversation

retornam
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Upgrades the Golang version to 1.23 to pickup updates to packages in the standard library as well as security fixes
Also updates the packages
k8s.io/kubernetes to v1.27.16 ( missed in a prior commit)
sigs.k8s.io/cloud-provider-azure to v1.27.21

Which issue(s) this PR fixes:

Fixes NONE

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE


Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE


Upgrade Go version to 1.23.0 for CI builds

Signed-off-by: retornam <[email protected]>
Also updatees the following Golang packages
k8s.io/kubernetes v1.27.16
sigs.k8s.io/cloud-provider-azure v1.27.21

Signed-off-by: retornam <[email protected]>
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 27, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @retornam. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 27, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: retornam
Once this PR has been reviewed and has the lgtm label, please assign gjtempleton for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 27, 2024
Signed-off-by: retornam <[email protected]>
@jackfrancis
Copy link
Contributor

/test pull-cluster-autoscaler-e2e-azure-master

@k8s-ci-robot
Copy link
Contributor

@jackfrancis: The specified target(s) for /test were not found.
The following commands are available to trigger optional jobs:

  • /test pull-cluster-autoscaler-e2e-azure-1-27
  • /test pull-kubernetes-e2e-autoscaling-vpa-full

In response to this:

/test pull-cluster-autoscaler-e2e-azure-master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jackfrancis
Copy link
Contributor

@retornam why are we doing this only into the 1.27 release branch?

@adrianmoisey
Copy link
Member

/area cluster-autoscaler

@retornam
Copy link
Contributor Author

retornam commented Oct 1, 2024

@retornam why are we doing this only into the 1.27 release branch?

I'll update the main branch as well. This is to resolve some Golang vulns

@retornam
Copy link
Contributor Author

retornam commented Oct 1, 2024

@jackfrancis #7318 should take care of the main branch as well

@retornam
Copy link
Contributor Author

retornam commented Oct 1, 2024

@gjtempleton can this be reviewed please. Thanks

@Shubham82
Copy link
Contributor

@retornam, we only support the last three releases from the latest release. The latest release is CA v1.31 and so the supported releases are CA 1.28-1.30.

@Shubham82
Copy link
Contributor

Shubham82 commented Oct 1, 2024

IMO we can't update the Golang version here, Cluster Autoscaler uses the same go version that is used by embedded Kubernetes code. For example, CA 1.27 will use the same go version as Kubernetes 1.27.

@retornam
Copy link
Contributor Author

retornam commented Oct 1, 2024

IMO we can't update the Golang version here, Cluster Autoscaler uses the same go version that is used by embedded Kubernetes code. For example, CA 1.27 will use the same go version as Kubernetes 1.27.

@Shubham82 But there have been cases where old releases were upgraded for security related fixes to Golang, this is one of those cases.

@Shubham82
Copy link
Contributor

@retornam, this will create a compatibility issue with k8s, also there will be no patch release for CA 1.27, see this issue:#7315

@gjtempleton @MaciekPytel WDYT?

@jackfrancis
Copy link
Contributor

IMO we can't update the Golang version here, Cluster Autoscaler uses the same go version that is used by embedded Kubernetes code. For example, CA 1.27 will use the same go version as Kubernetes 1.27.

This is the key for me as well.

https://github.com/kubernetes/kubernetes/blob/release-1.27/go.mod#L9

I don't see how we can cut 1) a new version that is already past the support window 2) with a version of golang that is 3 versions newer than the version of k/k at the equivalent release

@Shubham82
Copy link
Contributor

I don't see how we can cut 1) a new version that is already past the support window 2) with a version of golang that is 3 versions newer than the version of k/k at the equivalent release

IMO we can't do that.

cc @MaciekPytel @gjtempleton your thoughts on this?

Thanks!

@retornam retornam closed this Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants