-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates Golang version to 1.23 #7311
Updates Golang version to 1.23 #7311
Conversation
Upgrade Go version to 1.23.0 for CI builds Signed-off-by: retornam <[email protected]>
Also updatees the following Golang packages k8s.io/kubernetes v1.27.16 sigs.k8s.io/cloud-provider-azure v1.27.21 Signed-off-by: retornam <[email protected]>
Hi @retornam. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: retornam The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: retornam <[email protected]>
/test pull-cluster-autoscaler-e2e-azure-master |
@jackfrancis: The specified target(s) for
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@retornam why are we doing this only into the 1.27 release branch? |
/area cluster-autoscaler |
I'll update the main branch as well. This is to resolve some Golang vulns |
@jackfrancis #7318 should take care of the main branch as well |
@gjtempleton can this be reviewed please. Thanks |
@retornam, we only support the last three releases from the latest release. The latest release is CA v1.31 and so the supported releases are CA 1.28-1.30. |
IMO we can't update the Golang version here, Cluster Autoscaler uses the same go version that is used by embedded Kubernetes code. For example, CA 1.27 will use the same go version as Kubernetes 1.27. |
@Shubham82 But there have been cases where old releases were upgraded for security related fixes to Golang, this is one of those cases. |
@retornam, this will create a compatibility issue with k8s, also there will be no patch release for CA 1.27, see this issue:#7315 @gjtempleton @MaciekPytel WDYT? |
This is the key for me as well. https://github.com/kubernetes/kubernetes/blob/release-1.27/go.mod#L9 I don't see how we can cut 1) a new version that is already past the support window 2) with a version of golang that is 3 versions newer than the version of k/k at the equivalent release |
IMO we can't do that. cc @MaciekPytel @gjtempleton your thoughts on this? Thanks! |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Upgrades the Golang version to 1.23 to pickup updates to packages in the standard library as well as security fixes
Also updates the packages
k8s.io/kubernetes to v1.27.16 ( missed in a prior commit)
sigs.k8s.io/cloud-provider-azure to v1.27.21
Which issue(s) this PR fixes:
Fixes NONE
Special notes for your reviewer:
Does this PR introduce a user-facing change?
NONE
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
NONE