Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cluster-autoscaler-release-1.31] Dynamic listing of SKUs #7254

Merged
merged 3 commits into from
Sep 6, 2024
Merged

[cluster-autoscaler-release-1.31] Dynamic listing of SKUs #7254

merged 3 commits into from
Sep 6, 2024

Conversation

k8s-infra-cherrypick-robot
Copy link

This is an automated cherry-pick of #7239

/assign comtalyst

Deprecate option to enableDynamicInstanceList

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Sep 6, 2024
Merged
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 6, 2024
@k8s-ci-robot k8s-ci-robot added area/cluster-autoscaler area/provider/azure Issues or PRs related to azure provider size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 6, 2024
@rakechill
Copy link
Contributor

/retitle [cluster-autoscaler-release-1.31] Dynamic listing of SKUs

@k8s-ci-robot
Copy link
Contributor

@rakechill: Re-titling can only be requested by trusted users, like repository collaborators.

In response to this:

/retitle [cluster-autoscaler-release-1.31] Dynamic listing of SKUs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@nojnhuh
Copy link
Contributor

nojnhuh commented Sep 6, 2024

/retitle [cluster-autoscaler-release-1.31] Dynamic listing of SKUs

@k8s-ci-robot k8s-ci-robot changed the title [cluster-autoscaler-release-1.31] Dynamic listing of SKUs (master) [cluster-autoscaler-release-1.31] Dynamic listing of SKUs Sep 6, 2024
@comtalyst
Copy link
Contributor

/label tide/merge-method-squash
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Sep 6, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: comtalyst, k8s-infra-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 6, 2024
@k8s-ci-robot k8s-ci-robot merged commit e5ebbf6 into kubernetes:cluster-autoscaler-release-1.31 Sep 6, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@tallaxes tallaxes Awaiting requested review from tallaxes

Assignees

@comtalyst comtalyst

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@k8s-infra-cherrypick-robot @rakechill @k8s-ci-robot @nojnhuh @comtalyst