chore: defork labels and taints

[charliedmcb]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This is part of the deforking effort for Azure.

There are certain adjustments to the labels/taints process that make sense for consideration when constructing the node, and should be ported in for better accuracy.

This also, has some non-functional elements at the moment based on:

	inputLabels := map[string]string{}
	inputTaints := ""

These are inputs that'll be allowed as Azure specific settings within the future to allow for additional, more accurate expectations of labels/taints.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

	inputLabels := map[string]string{}
	inputTaints := ""

And the associated code are non-functional at the moment, but there will be a change coming down the line to make it functional. At the moment its just stubs to get the code in place, and should still work by taking the other still functional paths.

Does this PR introduce a user-facing change?

- Azure: certain scale from zero scenarios around labels will be more accurate

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[k8s-ci-robot]

Hi @charliedmcb. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[comtalyst]

Main changes lgtm. Is there anything in azure_template_test.go as well?

[charliedmcb]

Main changes lgtm. Is there anything in azure_template_test.go as well?

There is another method in azure_template_test.go. However, I didn't spot usage of it, so don't think it needs to be ported, and removed from the fork instead.

I still need to add testing as well.

[charliedmcb]

Main changes lgtm. Is there anything in azure_template_test.go as well?

Ok, with the change to passing in

inputLabels := map[string]string{}
inputTaints := ""

instead of having them within the function, this should be all the fork changes for both:

• azure_scale_set.go
• azure_scale_set_test.go

I'm going to look at adding some more testing though if easily possibly

[comtalyst]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: charliedmcb, comtalyst

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• cluster-autoscaler/cloudprovider/azure/OWNERS [comtalyst]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[comtalyst]

/hold

[comtalyst]

/ok-to-test

[charliedmcb]

/cherry-pick cluster-autoscaler-1.29

[k8s-infra-cherrypick-robot]

@charliedmcb: only kubernetes org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually.

In response to this:

/cherry-pick cluster-autoscaler-1.29

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[comtalyst]

/unhold

[comtalyst]

/cherry-pick cluster-autoscaler-release-1.29

[k8s-infra-cherrypick-robot]

@comtalyst: once the present PR merges, I will cherry-pick it on top of cluster-autoscaler-release-1.29 in a new PR and assign it to you.

In response to this:

/cherry-pick cluster-autoscaler-release-1.29

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-infra-cherrypick-robot]

@comtalyst: new pull request created: #7215

In response to this:

/cherry-pick cluster-autoscaler-release-1.29

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[comtalyst]

/cherry-pick cluster-autoscaler-release-1.30
/cherry-pick cluster-autoscaler-release-1.28
/cherry-pick cluster-autoscaler-release-1.27

[k8s-infra-cherrypick-robot]

@comtalyst: new pull request created: #7216

In response to this:

/cherry-pick cluster-autoscaler-release-1.30
/cherry-pick cluster-autoscaler-release-1.28
/cherry-pick cluster-autoscaler-release-1.27

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[comtalyst]

/cherry-pick cluster-autoscaler-release-1.28

[comtalyst]

/cherry-pick cluster-autoscaler-release-1.27

[k8s-infra-cherrypick-robot]

@comtalyst: new pull request created: #7224

In response to this:

/cherry-pick cluster-autoscaler-release-1.28

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-infra-cherrypick-robot]

@comtalyst: new pull request created: #7225

In response to this:

/cherry-pick cluster-autoscaler-release-1.27

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[comtalyst]

/cherry-pick cluster-autoscaler-release-1.31

[k8s-infra-cherrypick-robot]

@comtalyst: new pull request created: #7240

In response to this:

/cherry-pick cluster-autoscaler-release-1.31

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.