-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect wording in FAQ.md #7196
Conversation
Correct wording would be "above the maximum" which then goes on to explain how the CA handles scaling down a nodepool that is currently above the maxNodes value
The committers listed above are authorized under a signed CLA. |
Welcome @asobti! |
Hi @asobti. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
/lgtm |
/assign @x13n |
Good catch! /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: asobti, x13n The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Fixes incorrect wording would in an FAQ. The correct phrasing should be "above the maximum" which then goes on to explain how the CA handles scaling down a nodepool that is currently above the maxNodes value
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: