cherry-pick(1.28): HasInstance implementation #7114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/feature
k8s-ci-robot
added
the
area/provider/azure
Bryce-Soghigian
changed the title
fix: ci lint refactor: cloudprovider HasInstance should use case sensitive instance group lookup feat: using NodeGroupForNode for the azure provider has instance implementation fix: ci lint fix: ci wip: HasInstance impl based on a fork of NodeGroupForNode refactor: refactoring tests and sharing validation between ngfornode + hasinstance test: removing commented out test ci: fix formatting fix: properly handling unmanaged nodes fix: removing unused helper fix: using provider id to get scaleset name fix: putting items into the set as lowercase to avoid mismatch in lookup Update cluster-autoscaler/cloudprovider/azure/azure_cloud_provider.go Co-authored-by: Alex Leites <[email protected]> fix: always fallback if we are unsure an instance is in the cache test: adding back in TestNodeGroupForNodeWithNoProviderID refactor: removing log lines since this will spam for non-autoscaled nodes refactor: removing dead code fix: simplifying logic since we no longer distinguish on delete Update cluster-autoscaler/cloudprovider/azure/azure_cache.go test: renaming test to better reflect the scenario Update cluster-autoscaler/cloudprovider/azure/azure_cache.go Co-authored-by: Alex Leites <[email protected]> refactor: removing shared helpers since they are no longer shared and didnt make any sense in the first place refactor: removing unused code and adding a test for has instance happy path Update cluster-autoscaler/cloudprovider/azure/azure_cache.go ci: lint Update cluster-autoscaler/cloudprovider/azure/azure_cache.go Co-authored-by: Alex Leites <[email protected]> ci: lint
Bryce-Soghigian
force-pushed
the
bsoghigian/cp/hasinstance
branch
from
230b51a to
c2c53d5
Compare
Bryce-Soghigian
commented
Aug 2, 2024
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bryce-Soghigian, tallaxes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
merged commit 36c12f3
into
kubernetes:cluster-autoscaler-release-1.28
6 of 7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This pr cherry picks HasInstance into 1.28 #6956
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: