-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regenerate azure static sku list for 1.29 #7111
Regenerate azure static sku list for 1.29 #7111
Conversation
Hi @rakechill. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rakechill, tallaxes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
8a0a39b
into
kubernetes:cluster-autoscaler-release-1.29
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Regenerates the static sku list that acts as a fallback mechanism for dynamic listing
Special notes for your reviewer:
az vm --list-skus -o json
. The memory updates + deprecated types are accurate.go generate
for theazure/
folder, I received errors that were not present on 1.27 or 1.28. This was due to a change added by @wenxuan0923go generate
, and added it back. This change needs to be revisited sincego generate
does not work properly with it present.Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: