-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: upstream most of Azure managed CAS changes in cloudprovider/azure for 1.30 #7076
refactor: upstream most of Azure managed CAS changes in cloudprovider/azure for 1.30 #7076
Conversation
Hi @comtalyst. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
/test pull-cluster-autoscaler-e2e-azure |
@comtalyst: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: comtalyst, feiskyer, tallaxes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4d3a2b8
into
kubernetes:cluster-autoscaler-release-1.30
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
"Refactor" as a part of fork-upstream (managed-selfhosted) realignment. Should not have any breaking changes.
This codebases realignment will simplify the logistics between the two, cutting a significant portion of maintenance cost.
There will be a separate effort focusing on improve code quality, rather than realigning codebase.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
All are in cloudprovider/azure except go.mod, go.sum, and vendor.
Preferrably review master PR first, then compare it to here.
No significant differences.
Overall:
EnableDetailedCSEMessage
,GetVmssSizeRefreshPeriod
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: