Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ProvisioningRequest API with the new name of scale-up provisioning class #7032

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Update ProvisioningRequest API with the new name of scale-up provisioning class #7032

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cluster-autoscaler/apis/provisioningrequest/autoscaling.x-k8s.io/v1beta1/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ const (
// ProvisioningClassCheckCapacity denotes that CA will check if current cluster state can fulfill this request,
// and reserve the capacity for a specified time.
ProvisioningClassCheckCapacity string = "check-capacity.autoscaling.x-k8s.io"
// ProvisioningClassAtomicScaleUp denotes that CA try to provision the capacity
// ProvisioningClassBestEffortAtomicScaleUp denotes that CA try to provision the capacity
// in an atomic manner.
ProvisioningClassAtomicScaleUp string = "atomic-scale-up.autoscaling.x-k8s.io"
ProvisioningClassBestEffortAtomicScaleUp string = "best-effort-atomic-scale-up.autoscaling.x-k8s.io"
)
2 changes: 1 addition & 1 deletion cluster-autoscaler/provisioningrequest/orchestrator/orchestrator_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ func TestScaleUp(t *testing.T) {
CPU: "1",
Memory: "1",
PodCount: int32(5),
Class: v1beta1.ProvisioningClassAtomicScaleUp,
Class: v1beta1.ProvisioningClassBestEffortAtomicScaleUp,
})

// Already provisioned provisioning request - capacity should be booked before processing a new request.
Expand Down
4 changes: 2 additions & 2 deletions ...oscaler/cluster-autoscaler/apis/provisioningrequest/autoscaling.x-k8s.io/v1beta1/types.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading