Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove not yet supported parameter from admission-controller deployment #6988

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

voelzmo
Copy link
Contributor

@voelzmo voelzmo commented Jun 28, 2024

What type of PR is this?

/kind bug

What this PR does / why we need it:

Remove --reload-cert from the admission-controller deployment, as this references image version 1.1.2, which doesn't support this parameter yet. It will be available from version 1.2.0 onwards.

Which issue(s) this PR fixes:

Fixes #6977

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 28, 2024
@k8s-ci-robot k8s-ci-robot requested a review from jbartosik June 28, 2024 20:24
@k8s-ci-robot k8s-ci-robot requested a review from krzysied June 28, 2024 20:24
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 28, 2024
@voelzmo voelzmo changed the title Remove unsupported parameter from admission-controller Remove not yet supported parameter from admission-controller deployment Jun 28, 2024
@voelzmo
Copy link
Contributor Author

voelzmo commented Jun 28, 2024

/invite @kwiesmueller
seems like we accidentally let this in when merging #6665 – could you please approve so people can install VPA successfully again with the default yamls/scripts? Thanks!

@kwiesmueller
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 28, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kwiesmueller, voelzmo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 8cf630a into kubernetes:master Jun 28, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/vertical-pod-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"vpa-admission-controller" getting into CrashLoopBackOff in result to PR: #6665
3 participants