Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cluster-autoscaler-release-1.30] Refactor Provisioning Request orchestrator unit tests #6933

Conversation

k8s-infra-cherrypick-robot

This is an automated cherry-pick of #6779

/assign yaroslava-serdiuk

NONE

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/cluster-autoscaler labels Jun 17, 2024
@yaroslava-serdiuk
Copy link
Contributor

/assign @towca

@Shubham82
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 18, 2024
@Shubham82
Copy link
Contributor

cc Hi, @towca
Could you please approve this PR, so that it can be merged

Thanks!

@yaroslava-serdiuk
Copy link
Contributor

yaroslava-serdiuk commented Jul 3, 2024

The essential changes that should be cherry-picked were introduced in #6821, #6873.
Actually this PR is not needed to be cherry-picked in order to cherry-pick real changes, so it could be abandon. Sorry for not verifying it initially.

@yaroslava-serdiuk
Copy link
Contributor

/close

@k8s-ci-robot
Copy link
Contributor

@yaroslava-serdiuk: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@yaroslava-serdiuk
Copy link
Contributor

/reopen

@k8s-ci-robot k8s-ci-robot reopened this Jul 11, 2024
@k8s-ci-robot
Copy link
Contributor

@yaroslava-serdiuk: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@yaroslava-serdiuk
Copy link
Contributor

@x13n reopen this PR since it's needed to cherry-pick #6824

@x13n
Copy link
Member

x13n commented Jul 11, 2024

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k8s-infra-cherrypick-robot, x13n

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2024
@k8s-ci-robot k8s-ci-robot merged commit 0ed4b01 into kubernetes:cluster-autoscaler-release-1.30 Jul 11, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants