-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify logic to look for ocid type prefix in OCI cloud provider builder #6918
Modify logic to look for ocid type prefix in OCI cloud provider builder #6918
Conversation
Hi @vbhargav875. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlamillan, vbhargav875 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…dification Modify logic to look for ocid type prefix in OCI cloud provider builder
What type of PR is this?
/kind bug
What this PR does / why we need it:
In OKE, nodepools being created in a dev environment (integ) have the term nodepoolinteg instead of just nodepool . This is causing issues with CA. Our current logic in CA is to split the nodepool ocid by . as the separator and move the control to OKE's implementation if the string in the 1st index of the array is nodepool , else we move the control to Instance Pool's implementation. Since it is now nodepoolinteg , it is moving to Instance Pool's implementation. This PRs fixes the logic.
Does this PR introduce a user-facing change?
No