Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VPA: Add tests for selfRegistration() and filterVPAs() #6910

Merged
merged 2 commits into from
Jun 19, 2024
Merged

VPA: Add tests for selfRegistration() and filterVPAs() #6910

merged 2 commits into from
Jun 19, 2024

Conversation

adrianmoisey
Copy link
Member

What type of PR is this?

/kind bug

What this PR does / why we need it:

I'm working on another PR
(#6788) and realised that those changes will be touching code that is untested.

I decided to go back and add some tests before continuing work in that PR.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

I'm unsure if these tests match the current style of tests in the VPA. I'm happy to change if needed.

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@adrianmoisey
VPA: Add tests for selfRegistration() and filterVPAs()
306e735 
I'm working on another PR
(kubernetes#6788) and realised that
those changes will be touching code that is untested.

I decided to go back and add some tests before continuing work in that
PR.
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jun 10, 2024
@k8s-ci-robot k8s-ci-robot requested a review from voelzmo June 10, 2024 15:42
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 10, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @adrianmoisey. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 10, 2024
@raywainman
Copy link
Contributor

/ok-to-test

Thanks!!

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 11, 2024
raywainman
raywainman reviewed Jun 14, 2024
View reviewed changes
Copy link
Contributor

@raywainman raywainman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm just one small suggestion

Thanks for improving these tests!

vertical-pod-autoscaler/pkg/recommender/input/cluster_feeder_test.go Outdated
t.Fatalf("expected %d VPAs, got %d", len(expectedResult), len(result))
}

for i, vpa := range result {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about using https://pkg.go.dev/github.com/stretchr/[email protected]/assert#ElementsMatch to simplify this check?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great suggestion, thanks!

I've done that in 9c0941f

@adrianmoisey
Copy link
Member Author

Hey @raywainman
Any chance you have some time to look at this again?

@raywainman
Copy link
Contributor

raywainman commented Jun 18, 2024 •
edited
Loading

/lgtm thanks!

@adrianmoisey
Copy link
Member Author

Hey @raywainman
It looks like the /lgtm didn't work. I wonder if the "thanks!" tripped the bot up.
Can you try again?

@voelzmo
Copy link
Contributor

voelzmo commented Jun 19, 2024

/lgtm
/approve
Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 19, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrianmoisey, voelzmo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2024
@k8s-ci-robot k8s-ci-robot merged commit 49c4e05 into kubernetes:master Jun 19, 2024
7 checks passed
@adrianmoisey adrianmoisey deleted the add_tests branch June 19, 2024 11:38
@raywainman
Copy link
Contributor

Hey @raywainman It looks like the /lgtm didn't work. I wonder if the "thanks!" tripped the bot up. Can you try again?

Ha, sorry about that!

Thanks @voelzmo!

@raywainman raywainman mentioned this pull request Aug 6, 2024
Closed
@adrianmoisey adrianmoisey mentioned this pull request Sep 6, 2024
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raywainman raywainman raywainman left review comments

@kwiesmueller kwiesmueller Awaiting requested review from kwiesmueller

@voelzmo voelzmo Awaiting requested review from voelzmo

Assignees

@voelzmo voelzmo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/vertical-pod-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adrianmoisey @k8s-ci-robot @raywainman @voelzmo