-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ProvisioningRequest API with the new name of scale-up provisioning class #6854
Update ProvisioningRequest API with the new name of scale-up provisioning class #6854
Conversation
@aleksandra-malinowska: GitHub didn't allow me to request PR reviews from the following users: yaroslava, kisieland. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cc @towca Please let me know if you're unable to take a look and we need another approver. |
62c7a53
to
637b96d
Compare
/lgtm The names in the release note have a wrong suffix right? |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aleksandra-malinowska, towca The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Yes, I copied them from KEP since I was looking at it anyway, my bad. Fixed now. |
/cherry-pick cluster-autoscaler-release-1.30 |
@yaroslava-serdiuk: new pull request created: #7031 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@yaroslava-serdiuk: new pull request could not be created: failed to create pull request against kubernetes/autoscaler#cluster-autoscaler-release-1.30 from head k8s-infra-cherrypick-robot:cherry-pick-6854-to-cluster-autoscaler-release-1.30: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for k8s-infra-cherrypick-robot:cherry-pick-6854-to-cluster-autoscaler-release-1.30."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Changes the name of provisioning class from
atomic-scale-up.autoscaling.x-k8s.io
tobest-effort-atomic-scale-up.autoscaling.x-k8s.io
as agreed in #6849Which issue(s) this PR fixes:
Fixes #6849
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/cc @Yaroslava @kisieland