Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ProvisioningRequest API with the new name of scale-up provisioning class #6854

Merged

Conversation

aleksandra-malinowska
Copy link
Contributor

@aleksandra-malinowska aleksandra-malinowska commented May 22, 2024

What type of PR is this?

/kind bug

What this PR does / why we need it:

Changes the name of provisioning class from atomic-scale-up.autoscaling.x-k8s.io to best-effort-atomic-scale-up.autoscaling.x-k8s.io as agreed in #6849

Which issue(s) this PR fixes:

Fixes #6849

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Changed the name of provisioning class from `atomic-scale-up.autoscaling.x-k8s.io` to `best-effort-atomic-scale-up.autoscaling.x-k8s.io` in v1beta1. Note that this API is in draft stage and not yet supported in any release.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP] https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/proposals/provisioning-request.md

/cc @Yaroslava @kisieland

@k8s-ci-robot
Copy link
Contributor

@aleksandra-malinowska: GitHub didn't allow me to request PR reviews from the following users: yaroslava, kisieland.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

What type of PR is this?

/kind bug

What this PR does / why we need it:

Changes the name of provisioning class from atomic-scale-up.kubernetes.io to best-effort-atomic-scale-up.kubernetes.io as agreed in #6849

Which issue(s) this PR fixes:

Fixes #6849

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Changed the name of provisioning class from `atomic-scale-up.kubernetes.io` to `best-effort-atomic-scale-up.kubernetes.io` in v1beta1. Note that this API is in draft stage and not yet supported in any release.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP] https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/proposals/provisioning-request.md

/cc @Yaroslava @kisieland

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/cluster-autoscaler labels May 22, 2024
@aleksandra-malinowska
Copy link
Contributor Author

/cc @towca

Please let me know if you're unable to take a look and we need another approver.

@k8s-ci-robot k8s-ci-robot requested a review from towca May 22, 2024 10:52
@towca
Copy link
Collaborator

towca commented May 22, 2024

/lgtm
/approve

The names in the release note have a wrong suffix right?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 22, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aleksandra-malinowska, towca

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 22, 2024
@k8s-ci-robot k8s-ci-robot merged commit 4d88323 into kubernetes:master May 22, 2024
6 checks passed
@aleksandra-malinowska
Copy link
Contributor Author

The names in the release note have a wrong suffix right?

Yes, I copied them from KEP since I was looking at it anyway, my bad. Fixed now.

@yaroslava-serdiuk
Copy link
Contributor

/cherry-pick cluster-autoscaler-release-1.30

@k8s-infra-cherrypick-robot

@yaroslava-serdiuk: new pull request created: #7031

In response to this:

/cherry-pick cluster-autoscaler-release-1.30

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot

@yaroslava-serdiuk: new pull request could not be created: failed to create pull request against kubernetes/autoscaler#cluster-autoscaler-release-1.30 from head k8s-infra-cherrypick-robot:cherry-pick-6854-to-cluster-autoscaler-release-1.30: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for k8s-infra-cherrypick-robot:cherry-pick-6854-to-cluster-autoscaler-release-1.30."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}

In response to this:

/cherry-pick cluster-autoscaler-release-1.30

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename atomic-scale-up.kubernetes.io to best-effort-atomic-scale-up.kubernetes.io
5 participants