fix: implement function to identify if node is present in cluster-api

[MaxFedotov]

• this is a follow-up to Identifying cloud provider deleted nodes #5054
• this might fix CA fails to scale-up or cancel in-progress scale down when there are un-schedulable pods CA fails to scale-up or cancel in-progress scale down when there are un-schedulable pods  #4456
• this implements the same functionality, which was implemented it fix: implement function to identify if node is present in aws #5632 for aws provider

What type of PR is this?

/kind bug

What this PR does / why we need it:

The same as in #5632, but for cluster-api provider

I think description of #5054 (comment) explains it well:

...original intent of determining the deleted nodes was incorrect, which led to the issues reported by other users. The nodes tainted with ToBeDeleted were misidentified as Deleted instead of Ready/Unready, which caused a miscalculation of the node being included as Upcoming. This caused problems described in #3949 and #4456.

#5054 exposed interface function HasInstance for cloud providers to implement. This function is used to determine if a node is deleted by querying the cloud provider. It falls back to the ToBeDeleted taint if the function is not implemented.

Which issue(s) this PR fixes:

Fixes #4456

Special notes for your reviewer:

The same changes were already implemented in #5632 for AWS provider

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

[k8s-ci-robot]

Hi @MaxFedotov. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[elmiko]

/ok-to-test

[elmiko]

i think this is great @MaxFedotov , thanks for filling in this missing piece =)

i just added ok-to-test, i'd just like to make sure everything passes then i'll add approve.

/lgtm

[elmiko]

looks like it did already

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elmiko, MaxFedotov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• cluster-autoscaler/cloudprovider/clusterapi/OWNERS [elmiko]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment