Backport #6617 ionoscloud: Update ionos-cloud sdk-go and add metrics into CA 1.28 #6630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ionoscloud: Update ionos-cloud sdk-go and add metrics
k8s-ci-robot
added
do-not-merge/work-in-progress
|
/area cluster-autoscaler |
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
piepmatz
approved these changes
Mar 13, 2024
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: avorima, mwielgus, piepmatz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
merged commit 67895bf
into
kubernetes:cluster-autoscaler-release-1.28
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
/kind feature
What this PR does / why we need it:
This PR is cherry-picked, which backports #6617 into CA 1.28.
Special notes for your reviewer:
This version of the CA uses go 1.20, so I added a placeholder for
maps.DeleteFuncwhich was introduced in go 1.21.I also copied the
Tofunction fromk8s.io/utils/ptrpackage, because it wasn't vendored and wanted to keep the backport focused on the cloudprovider changes.Does this PR introduce a user-facing change?