Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop autoscaler vendor directory in favor of Go modules #6572

Merged
merged 2 commits into from
May 10, 2024
Merged

Drop autoscaler vendor directory in favor of Go modules #6572

merged 2 commits into from
May 10, 2024

Conversation

fmuyassarov
Copy link
Member

@fmuyassarov fmuyassarov commented Feb 27, 2024 •
edited
Loading

What type of PR is this?

/kind cleanup
/kind deprecation

What this PR does / why we need it:

Drop auto-scaler vendor directory in favor of Go modules. We're starting the process of moving away
from our auto-scaler vendor directory to adopt Go modules. This pull request will be paused for at least
two months (as agreed in #4878) to ensure the community has enough time to update their dependent
systems.

/hold

Which issue(s) this PR fixes:

Fixes # #4878

Special notes for your reviewer:

An echo statement for the build Makefile target in #6573.

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 27, 2024
@fmuyassarov fmuyassarov mentioned this pull request Feb 27, 2024
Merged
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 27, 2024
@fmuyassarov fmuyassarov force-pushed the devel/drop-vendor-dir branch from d31d575 to 4d43640 Compare February 27, 2024 08:27
@fmuyassarov fmuyassarov mentioned this pull request Feb 27, 2024
Closed
@fmuyassarov fmuyassarov changed the title Drop autoscaler vendor directory in favor of Go modules WIP: Drop autoscaler vendor directory in favor of Go modules Feb 27, 2024
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 27, 2024
@vadasambar
Copy link
Member

@fmuyassarov feel free to mention me here once we are past the 2 months mark. I will take a look!

@fmuyassarov
Copy link
Member Author

As agreed originally, the plan to land this PR was in two months. This means, we should expect the PR to be merged close to the end of April, 2024 if there are no objections.

@fmuyassarov fmuyassarov force-pushed the devel/drop-vendor-dir branch from 4d43640 to 8ee8331 Compare May 5, 2024 08:55
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 5, 2024
@fmuyassarov fmuyassarov force-pushed the devel/drop-vendor-dir branch from 56babdc to 0077481 Compare May 5, 2024 10:29
@fmuyassarov
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 5, 2024
@fmuyassarov fmuyassarov changed the title WIP: Drop autoscaler vendor directory in favor of Go modules Drop autoscaler vendor directory in favor of Go modules May 5, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 5, 2024
@fmuyassarov
Copy link
Member Author

@x13n @Shubham82 @vadasambar PTAL

elmiko
elmiko reviewed May 7, 2024
View reviewed changes
Copy link
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for taking the time to broadcast this for the community.

lgtm from me

x13n
x13n requested changes May 7, 2024
View reviewed changes
Copy link
Member

@x13n x13n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make sure make build-in-docker works after these changes? Current version seems unhappy about the vendor being missing.

hack/for-go-proj.sh Outdated Show resolved Hide resolved
@x13n
Copy link
Member

x13n commented May 7, 2024

/assign

@fmuyassarov fmuyassarov force-pushed the devel/drop-vendor-dir branch from 0077481 to 336046b Compare May 8, 2024 08:19
@fmuyassarov
Copy link
Member Author

fmuyassarov commented May 8, 2024 •
edited
Loading

Can you make sure make build-in-docker works after these changes? Current version seems unhappy about the vendor being missing.

Can you please share what issue are you facing when building the binary? Because, I just tested it and didn't catch an issue.
Example run:

@fmuyassarov ➜ /workspaces/autoscaler/cluster-autoscaler (devel/drop-vendor-dir) $ make build-in-docker
rm -f cluster-autoscaler-amd64
docker build --network=default -t autoscaling-builder ../builder
[+] Building 73.8s (10/10) FINISHED                                                                                                                                                                                                                                                            docker:default
 => [internal] load build definition from Dockerfile                                                                                                                                                                                                                                                     0.4s
 => => transferring dockerfile: 947B                                                                                                                                                                                                                                                                     0.0s
 => [internal] load .dockerignore                                                                                                                                                                                                                                                                        0.4s
 => => transferring context: 2B                                                                                                                                                                                                                                                                          0.0s
 => [internal] load metadata for docker.io/library/golang:1.22.2                                                                                                                                                                                                                                         1.6s
 => [auth] library/golang:pull token for registry-1.docker.io                                                                                                                                                                                                                                            0.0s
 => [1/5] FROM docker.io/library/golang:1.22.2@sha256:d5302d40dc5fbbf38ec472d1848a9d2391a13f93293a6a5b0b87c99dc0eaa6ae                                                                                                                                                                                  28.0s
 => => resolve docker.io/library/golang:1.22.2@sha256:d5302d40dc5fbbf38ec472d1848a9d2391a13f93293a6a5b0b87c99dc0eaa6ae                                                                                                                                                                                   0.2s
 => => sha256:5370d4968adad7e969494e744c6d28a93931b89f259accf4d08a94c30446d3a3 1.79kB / 1.79kB                                                                                                                                                                                                           0.0s
 => => sha256:d5302d40dc5fbbf38ec472d1848a9d2391a13f93293a6a5b0b87c99dc0eaa6ae 2.13kB / 2.13kB                                                                                                                                                                                                           0.0s
 => => sha256:0505a58fa4646ca8c19699d99a1053c789d00d9424ee9d8ed4d988e7642d1672 2.88kB / 2.88kB                                                                                                                                                                                                           0.0s
 => => sha256:1468e7ff95fcb865fbc4dee7094f8b99c4dcddd6eb2180cf044c7396baf6fc2f 49.58MB / 49.58MB                                                                                                                                                                                                         1.3s
 => => sha256:2cf9c2b42f41b1845f3e4421b723d56146db82939dc884555e077768e18132f4 24.05MB / 24.05MB                                                                                                                                                                                                         0.9s
 => => sha256:c4c40c3e3cdf945721f480e1d939aac857876fdb5c33b8fbfcf655c63b0b9428 64.14MB / 64.14MB                                                                                                                                                                                                         1.9s
 => => sha256:18445a9ea386c08b9cd5a46a17c8099d961d6813c6f5945e2adeb24ba596456a 92.41MB / 92.41MB                                                                                                                                                                                                         3.2s
 => => sha256:869f438912de025a33ddefebc1b04b8ba32dcb126a2cac0203aaf454384f626c 69.33MB / 69.33MB                                                                                                                                                                                                         9.6s
 => => extracting sha256:1468e7ff95fcb865fbc4dee7094f8b99c4dcddd6eb2180cf044c7396baf6fc2f                                                                                                                                                                                                                3.6s
 => => sha256:35955cffce03e15663107c788902ad19762864ee7aa47cccd893d3c80279de9e 174B / 174B                                                                                                                                                                                                               2.1s
 => => sha256:4f4fb700ef54461cfa02571ae0db9a0dc1e0cdb5577484a6d75e68dc38e8acc1 32B / 32B                                                                                                                                                                                                                 2.4s
 => => extracting sha256:2cf9c2b42f41b1845f3e4421b723d56146db82939dc884555e077768e18132f4                                                                                                                                                                                                                0.9s
 => => extracting sha256:c4c40c3e3cdf945721f480e1d939aac857876fdb5c33b8fbfcf655c63b0b9428                                                                                                                                                                                                                4.1s
 => => extracting sha256:18445a9ea386c08b9cd5a46a17c8099d961d6813c6f5945e2adeb24ba596456a                                                                                                                                                                                                                4.0s
 => => extracting sha256:869f438912de025a33ddefebc1b04b8ba32dcb126a2cac0203aaf454384f626c                                                                                                                                                                                                                5.9s
 => => extracting sha256:35955cffce03e15663107c788902ad19762864ee7aa47cccd893d3c80279de9e                                                                                                                                                                                                                0.0s
 => => extracting sha256:4f4fb700ef54461cfa02571ae0db9a0dc1e0cdb5577484a6d75e68dc38e8acc1                                                                                                                                                                                                                0.0s
 => [2/5] RUN apt-get update && apt-get --yes install libseccomp-dev                                                                                                                                                                                                                                     5.3s
 => [3/5] RUN go version                                                                                                                                                                                                                                                                                 0.6s 
 => [4/5] RUN go install github.com/tools/godep@latest                                                                                                                                                                                                                                                  29.7s 
 => [5/5] RUN godep version                                                                                                                                                                                                                                                                              0.6s 
 => exporting to image                                                                                                                                                                                                                                                                                   7.2s 
 => => exporting layers                                                                                                                                                                                                                                                                                  7.2s 
 => => writing image sha256:9d22df443b946563ad1a60ef636bf892acdfe9663733a856000325187e4a26e6                                                                                                                                                                                                             0.0s 
 => => naming to docker.io/library/autoscaling-builder                                                                                                                                                                                                                                                   0.0s 
docker run  -v `pwd`:/gopath/src/k8s.io/autoscaler/cluster-autoscaler/:Z autoscaling-builder:latest \                                                                                                                                                                                                         
        bash -c 'cd /gopath/src/k8s.io/autoscaler/cluster-autoscaler && BUILD_TAGS= LDFLAGS="-s" make build-arch-amd64'
rm -f cluster-autoscaler-amd64
CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -o cluster-autoscaler-amd64 --ldflags "-s" 
go: downloading github.com/spf13/pflag v1.0.5
go: downloading k8s.io/apimachinery v0.30.0-alpha.3
go: downloading k8s.io/apiserver v0.30.0-alpha.3
go: downloading k8s.io/client-go v0.30.0-alpha.3
go: downloading k8s.io/component-base v0.30.0-alpha.3
go: downloading k8s.io/klog/v2 v2.120.1
go: downloading k8s.io/kubernetes v1.30.0-alpha.3
go: downloading github.com/gogo/protobuf v1.3.2
go: downloading github.com/google/gofuzz v1.2.0
go: downloading github.com/emicklei/go-restful/v3 v3.11.0
go: downloading k8s.io/kube-openapi v0.0.0-20231113174909-778a5567bc1e
go: downloading k8s.io/api v0.30.0-alpha.3
go: downloading k8s.io/utils v0.0.0-20230726121419-3b25d923346b
go: downloading k8s.io/component-helpers v0.30.0-alpha.3
go: downloading github.com/stretchr/testify v1.8.4
go: downloading golang.org/x/net v0.20.0
go: downloading github.com/spf13/cobra v1.7.0
go: downloading github.com/go-logr/logr v1.4.1
go: downloading github.com/google/go-cmp v0.6.0
go: downloading github.com/prometheus/client_golang v1.16.0
go: downloading sigs.k8s.io/structured-merge-diff/v4 v4.4.1
go: downloading gopkg.in/inf.v0 v0.9.1
go: downloading go.opentelemetry.io/otel v1.19.0
go: downloading github.com/NYTimes/gziphandler v1.1.1
go: downloading github.com/golang/protobuf v1.5.3
go: downloading github.com/google/gnostic-models v0.6.8
go: downloading github.com/google/uuid v1.6.0
go: downloading github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822
go: downloading github.com/go-openapi/jsonreference v0.20.2
go: downloading github.com/go-openapi/swag v0.22.3
go: downloading k8s.io/kube-scheduler v0.30.0-alpha.3
go: downloading github.com/imdario/mergo v0.3.15
go: downloading golang.org/x/term v0.17.0
go: downloading gopkg.in/yaml.v2 v2.4.0
go: downloading k8s.io/cloud-provider v0.30.0-alpha.3
go: downloading gopkg.in/gcfg.v1 v1.2.3
go: downloading k8s.io/cloud-provider-aws v1.27.0
go: downloading github.com/Azure/azure-sdk-for-go v68.0.0+incompatible
go: downloading github.com/Azure/go-autorest/autorest v0.11.29
go: downloading github.com/Azure/go-autorest/autorest/adal v0.9.23
go: downloading github.com/Azure/go-autorest v14.2.0+incompatible
go: downloading github.com/Azure/go-autorest/autorest/azure/auth v0.5.8
go: downloading github.com/Azure/go-autorest/autorest/to v0.4.0
go: downloading github.com/Azure/skewer v0.0.14
go: downloading github.com/pkg/errors v0.9.1
go: downloading golang.org/x/crypto v0.19.0
go: downloading sigs.k8s.io/cloud-provider-azure v1.28.0
go: downloading github.com/digitalocean/godo v1.27.0
go: downloading golang.org/x/oauth2 v0.10.0
go: downloading google.golang.org/grpc v1.58.3
go: downloading sigs.k8s.io/yaml v1.3.0
go: downloading cloud.google.com/go/compute/metadata v0.2.3
go: downloading cloud.google.com/go/compute v1.23.0
go: downloading google.golang.org/api v0.126.0
go: downloading k8s.io/legacy-cloud-providers v0.30.0-alpha.3
go: downloading github.com/gofrs/uuid v4.4.0+incompatible
go: downloading github.com/blang/semver/v4 v4.0.0
go: downloading github.com/prometheus/client_model v0.4.0
go: downloading github.com/prometheus/procfs v0.10.1
go: downloading github.com/onsi/ginkgo/v2 v2.16.0
go: downloading github.com/onsi/gomega v1.31.1
go: downloading k8s.io/code-generator v0.30.0-alpha.3
go: downloading google.golang.org/protobuf v1.31.0
go: downloading github.com/golang/groupcache v0.0.0-20210331224755-41bb18bfe9da
go: downloading github.com/davecgh/go-spew v1.1.1
go: downloading gopkg.in/yaml.v3 v3.0.1
go: downloading golang.org/x/time v0.3.0
go: downloading github.com/go-logr/zapr v1.3.0
go: downloading go.uber.org/zap v1.26.0
go: downloading github.com/beorn7/perks v1.0.1
go: downloading github.com/cespare/xxhash/v2 v2.2.0
go: downloading github.com/prometheus/common v0.44.0
go: downloading sigs.k8s.io/json v0.0.0-20221116044647-bc3834ca7abd
go: downloading github.com/json-iterator/go v1.1.12
go: downloading go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.44.0
go: downloading go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.19.0
go: downloading go.opentelemetry.io/otel/sdk v1.19.0
go: downloading go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.19.0
go: downloading go.opentelemetry.io/otel/trace v1.19.0
go: downloading github.com/go-openapi/jsonpointer v0.19.6
go: downloading k8s.io/apiextensions-apiserver v0.30.0-alpha.3
go: downloading github.com/mailru/easyjson v0.7.7
go: downloading golang.org/x/sys v0.17.0
go: downloading gopkg.in/warnings.v0 v0.1.2
go: downloading github.com/aws/aws-sdk-go v1.44.241
go: downloading k8s.io/csi-translation-lib v0.30.0-alpha.3
go: downloading github.com/Azure/go-autorest/autorest/date v0.3.0
go: downloading github.com/Azure/go-autorest/autorest/validation v0.3.1
go: downloading github.com/Azure/go-autorest/tracing v0.6.0
go: downloading github.com/Azure/go-autorest/logger v0.2.1
go: downloading github.com/golang-jwt/jwt/v4 v4.5.0
go: downloading github.com/Azure/go-autorest/autorest/azure/cli v0.4.2
go: downloading github.com/dimchansky/utfbom v1.1.1
go: downloading github.com/stretchr/objx v0.5.0
go: downloading github.com/Azure/go-autorest/autorest/mocks v0.4.2
go: downloading github.com/golang/mock v1.6.0
go: downloading github.com/google/go-querystring v1.0.0
go: downloading google.golang.org/genproto/googleapis/rpc v0.0.0-20230822172742-b8732ec3820d
go: downloading google.golang.org/genproto v0.0.0-20230803162519-f966b187b2e5
go: downloading k8s.io/kubelet v0.30.0-alpha.3
go: downloading github.com/GoogleCloudPlatform/k8s-cloud-provider v1.18.1-0.20220218231025-f11817397a1b
go: downloading github.com/evanphx/json-patch v5.6.0+incompatible
go: downloading k8s.io/dynamic-resource-allocation v0.30.0-alpha.3
go: downloading go.uber.org/multierr v1.11.0
go: downloading github.com/matttproud/golang_protobuf_extensions v1.0.4
go: downloading golang.org/x/text v0.14.0
go: downloading github.com/felixge/httpsnoop v1.0.3
go: downloading go.opentelemetry.io/otel/metric v1.19.0
go: downloading github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd
go: downloading github.com/modern-go/reflect2 v1.0.2
go: downloading go.opentelemetry.io/proto/otlp v1.0.0
go: downloading github.com/josharian/intern v1.0.0
go: downloading github.com/jmespath/go-jmespath v0.4.0
go: downloading github.com/mitchellh/go-homedir v1.1.0
go: downloading github.com/google/s2a-go v0.1.7
go: downloading github.com/googleapis/gax-go/v2 v2.11.0
go: downloading go.opencensus.io v0.24.0
go: downloading github.com/cenkalti/backoff/v4 v4.2.1
go: downloading github.com/opencontainers/selinux v1.11.0
go: downloading k8s.io/mount-utils v0.30.0-alpha.3
go: downloading github.com/go-logr/stdr v1.2.2
go: downloading github.com/grpc-ecosystem/grpc-gateway/v2 v2.16.0
go: downloading github.com/googleapis/enterprise-certificate-proxy v0.2.3
go: downloading github.com/moby/sys/mountinfo v0.6.2
go: downloading google.golang.org/genproto/googleapis/api v0.0.0-20230726155614-23370e0ffb3e
go: downloading github.com/distribution/reference v0.5.0
go: downloading k8s.io/controller-manager v0.30.0-alpha.3
go: downloading github.com/opencontainers/go-digest v1.0.0
go: downloading github.com/coreos/go-systemd/v22 v22.5.0
go: downloading github.com/fsnotify/fsnotify v1.7.0
go: downloading gopkg.in/natefinch/lumberjack.v2 v2.2.1
go: downloading github.com/google/cel-go v0.17.7
go: downloading sigs.k8s.io/apiserver-network-proxy/konnectivity-client v0.29.0
go: downloading k8s.io/kms v0.30.0-alpha.3
go: downloading github.com/grpc-ecosystem/go-grpc-prometheus v1.2.0
go: downloading go.etcd.io/etcd/client/pkg/v3 v3.5.10
go: downloading go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.42.0
go: downloading go.etcd.io/etcd/client/v3 v3.5.10
go: downloading github.com/stoewer/go-strcase v1.3.0
go: downloading golang.org/x/sync v0.6.0
go: downloading go.etcd.io/etcd/api/v3 v3.5.10
go: downloading github.com/asaskevich/govalidator v0.0.0-20230301143203-a9d515a09cc2
go: downloading github.com/antlr/antlr4/runtime/Go/antlr/v4 v4.0.0-20230321174746-8dcc6526cfb1
go: downloading github.com/coreos/go-semver v0.3.1
go: downloading golang.org/x/exp v0.0.0-20230321023759-10a507213a29

@fmuyassarov ➜ /workspaces/autoscaler/cluster-autoscaler (devel/drop-vendor-dir) $ 
@fmuyassarov ➜ /workspaces/autoscaler/cluster-autoscaler (devel/drop-vendor-dir) $ ls
Dockerfile.amd64  Dockerfile.s390x  Makefile  README.md  cloudbuild.yaml  cluster-autoscaler-amd64  config   core               estimator  go.mod  hack  main.go       metrics    processors  provisioningrequest  simulator      utils
Dockerfile.arm64  FAQ.md            OWNERS    apis       cloudprovider    clusterstate              context  debuggingsnapshot  expander   go.sum  loop  main_test.go  observers  proposals   push_image.sh        update_toc.py  version
@fmuyassarov ➜ /workspaces/autoscaler/cluster-autoscaler (devel/drop-vendor-dir) $ docker images
REPOSITORY            TAG       IMAGE ID       CREATED         SIZE
autoscaling-builder   latest    9d22df443b94   9 minutes ago   963MB
@fmuyassarov ➜ /workspaces/autoscaler/cluster-autoscaler (devel/drop-vendor-dir) $ ./cluster-autoscaler-amd64 
F0508 08:18:40.755831   17970 client.go:61] Failed to build Kubernetes client configuration: unable to load in-cluster configuration, KUBERNETES_SERVICE_HOST and KUBERNETES_SERVICE_PORT must be defined

@fmuyassarov fmuyassarov requested a review from x13n May 8, 2024 08:47
@x13n
Copy link
Member

x13n commented May 9, 2024

Hm... interesting. For me it doesn't work, perhaps some difference in docker vs docker cli experimental?

$ git log --graph -2
* commit 007748164366cba4f715fa20ce8786f39bcae5e4 (HEAD)
| Author: Feruzjon Muyassarov <[email protected]>
| Date:   Sun May 5 13:22:47 2024 +0300
| 
|     update testing script to accommodate changes in vendor directory handling
|     
|     Signed-off-by: Feruzjon Muyassarov <[email protected]>
| 
* commit 8ee83313291c6747575108293ee806f01a2c2ded
| Author: Feruzjon Muyassarov <[email protected]>
| Date:   Sun May 5 11:52:43 2024 +0300
| 
|     Drop vendor direcotry in favor of Go modules
|     
|     Signed-off-by: Feruzjon Muyassarov <[email protected]>
$ make clean
rm -f cluster-autoscaler-amd64
$ make build-in-docker 
rm -f cluster-autoscaler-amd64
docker build --network=default -t autoscaling-builder ../builder
Sending build context to Docker daemon  4.608kB
Step 1/10 : FROM golang:1.22.2
 ---> 0505a58fa464
Step 2/10 : LABEL maintainer="Marcin Wielgus <[email protected]>"
 ---> Using cache
 ---> 1e8535139fc3
Step 3/10 : ENV GOPATH /gopath/
 ---> Using cache
 ---> f0c08fc3fe39
Step 4/10 : ENV PATH $GOPATH/bin:$PATH
 ---> Using cache
 ---> 859a7989fc10
Step 5/10 : ENV GO111MODULE auto
 ---> Using cache
 ---> e27181e09fef
Step 6/10 : RUN apt-get update && apt-get --yes install libseccomp-dev
 ---> Using cache
 ---> bb98ca51263b
Step 7/10 : RUN go version
 ---> Using cache
 ---> dff1a071726a
Step 8/10 : RUN go install github.com/tools/godep@latest
 ---> Using cache
 ---> b6891bd7c373
Step 9/10 : RUN godep version
 ---> Using cache
 ---> c5467bf55cdb
Step 10/10 : CMD ["/bin/bash"]
 ---> Using cache
 ---> 91d7964672c4
Successfully built 91d7964672c4
Successfully tagged autoscaling-builder:latest
docker run  -v `pwd`:/gopath/src/k8s.io/autoscaler/cluster-autoscaler/:Z autoscaling-builder:latest \
	bash -c 'cd /gopath/src/k8s.io/autoscaler/cluster-autoscaler && BUILD_TAGS= LDFLAGS="-s" make build-arch-amd64'
rm -f cluster-autoscaler-amd64
CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -o cluster-autoscaler-amd64 --ldflags "-s" 
go: inconsistent vendoring in /gopath/src/k8s.io/autoscaler/cluster-autoscaler:
	cloud.google.com/go/compute/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/Azure/[email protected]+incompatible: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/Azure/go-autorest/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/Azure/go-autorest/autorest/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/Azure/go-autorest/autorest/azure/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/Azure/go-autorest/autorest/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/Azure/go-autorest/autorest/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/Azure/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/aws/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/cenkalti/backoff/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/digitalocean/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/gofrs/[email protected]+incompatible: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/golang/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/google/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/google/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/google/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/jmespath/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/json-iterator/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/pkg/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/prometheus/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/spf13/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/stretchr/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	golang.org/x/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	golang.org/x/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	golang.org/x/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	golang.org/x/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	google.golang.org/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	google.golang.org/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	google.golang.org/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	gopkg.in/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	gopkg.in/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	k8s.io/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	k8s.io/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	k8s.io/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	k8s.io/autoscaler/cluster-autoscaler/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	k8s.io/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	k8s.io/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	k8s.io/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	k8s.io/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	k8s.io/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	k8s.io/klog/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	k8s.io/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	k8s.io/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	k8s.io/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	k8s.io/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	sigs.k8s.io/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	sigs.k8s.io/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	cloud.google.com/go/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/Azure/[email protected]+incompatible: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/Azure/go-autorest/autorest/azure/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/Azure/go-autorest/autorest/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/Azure/go-autorest/autorest/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/Azure/go-autorest/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/Azure/go-autorest/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/GoogleCloudPlatform/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/JeffAshton/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/Microsoft/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/Microsoft/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/NYTimes/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/antlr/antlr4/runtime/Go/antlr/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/armon/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/asaskevich/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/beorn7/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/blang/semver/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/cespare/xxhash/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/checkpoint-restore/go-criu/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/cilium/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/container-storage-interface/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/containerd/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/containerd/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/containerd/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/coreos/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/coreos/go-systemd/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/cyphar/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/davecgh/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/dimchansky/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/distribution/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/dnaeon/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/docker/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/emicklei/go-restful/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/euank/[email protected]+incompatible: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/evanphx/[email protected]+incompatible: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/felixge/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/fsnotify/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/go-logr/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/go-logr/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/go-logr/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/go-openapi/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/go-openapi/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/go-openapi/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/go-task/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/godbus/dbus/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/gogo/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/golang-jwt/jwt/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/golang/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/golang/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/google/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/google/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/google/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/google/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/google/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/google/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/googleapis/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/googleapis/gax-go/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/gorilla/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/grpc-ecosystem/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/grpc-ecosystem/grpc-gateway/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/imdario/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/inconshreveable/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/josharian/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/karrick/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/libopenstorage/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/mailru/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/matttproud/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/mistifyio/[email protected]+incompatible: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/mitchellh/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/moby/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/moby/sys/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/modern-go/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/modern-go/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/mohae/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/mrunalp/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/munnerz/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/mxk/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/onsi/ginkgo/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/onsi/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/opencontainers/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/opencontainers/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/opencontainers/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/opencontainers/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/pmezard/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/prometheus/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/prometheus/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/prometheus/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/seccomp/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/sirupsen/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/spf13/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/stoewer/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/stretchr/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/syndtr/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/vishvananda/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/vishvananda/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	go.etcd.io/etcd/api/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	go.etcd.io/etcd/client/pkg/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	go.etcd.io/etcd/client/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	go.opentelemetry.io/contrib/instrumentation/github.com/emicklei/go-restful/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	go.opentelemetry.io/contrib/instrumentation/net/http/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	go.opentelemetry.io/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	go.opentelemetry.io/otel/exporters/otlp/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	go.opentelemetry.io/otel/exporters/otlp/otlptrace/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	go.opentelemetry.io/otel/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	go.opentelemetry.io/otel/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	go.opentelemetry.io/otel/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	go.opentelemetry.io/proto/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	go.uber.org/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	go.uber.org/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	golang.org/x/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	golang.org/x/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	golang.org/x/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	golang.org/x/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	golang.org/x/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	golang.org/x/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	golang.org/x/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	google.golang.org/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	google.golang.org/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	google.golang.org/genproto/googleapis/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	google.golang.org/genproto/googleapis/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	gopkg.in/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	gopkg.in/natefinch/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	gopkg.in/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	gopkg.in/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	k8s.io/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	k8s.io/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	k8s.io/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	k8s.io/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	k8s.io/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	k8s.io/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	k8s.io/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	k8s.io/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	k8s.io/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	k8s.io/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	k8s.io/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	k8s.io/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	sigs.k8s.io/apiserver-network-proxy/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	sigs.k8s.io/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	sigs.k8s.io/structured-merge-diff/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/aws/aws-sdk-go/service/eks: is replaced in go.mod, but not marked as replaced in vendor/modules.txt
	github.com/digitalocean/godo: is replaced in go.mod, but not marked as replaced in vendor/modules.txt
	github.com/rancher/go-rancher: is replaced in go.mod, but not marked as replaced in vendor/modules.txt
	k8s.io/api: is replaced in go.mod, but not marked as replaced in vendor/modules.txt
	k8s.io/apiextensions-apiserver: is replaced in go.mod, but not marked as replaced in vendor/modules.txt
	k8s.io/apimachinery: is replaced in go.mod, but not marked as replaced in vendor/modules.txt
	k8s.io/apiserver: is replaced in go.mod, but not marked as replaced in vendor/modules.txt
	k8s.io/cli-runtime: is replaced in go.mod, but not marked as replaced in vendor/modules.txt
	k8s.io/client-go: is replaced in go.mod, but not marked as replaced in vendor/modules.txt
	k8s.io/cloud-provider: is replaced in go.mod, but not marked as replaced in vendor/modules.txt
	k8s.io/cluster-bootstrap: is replaced in go.mod, but not marked as replaced in vendor/modules.txt
	k8s.io/code-generator: is replaced in go.mod, but not marked as replaced in vendor/modules.txt
	k8s.io/component-base: is replaced in go.mod, but not marked as replaced in vendor/modules.txt
	k8s.io/component-helpers: is replaced in go.mod, but not marked as replaced in vendor/modules.txt
	k8s.io/controller-manager: is replaced in go.mod, but not marked as replaced in vendor/modules.txt
	k8s.io/cri-api: is replaced in go.mod, but not marked as replaced in vendor/modules.txt
	k8s.io/csi-translation-lib: is replaced in go.mod, but not marked as replaced in vendor/modules.txt
	k8s.io/kube-aggregator: is replaced in go.mod, but not marked as replaced in vendor/modules.txt
	k8s.io/kube-controller-manager: is replaced in go.mod, but not marked as replaced in vendor/modules.txt
	k8s.io/kube-proxy: is replaced in go.mod, but not marked as replaced in vendor/modules.txt
	k8s.io/kube-scheduler: is replaced in go.mod, but not marked as replaced in vendor/modules.txt
	k8s.io/kubectl: is replaced in go.mod, but not marked as replaced in vendor/modules.txt
	k8s.io/kubelet: is replaced in go.mod, but not marked as replaced in vendor/modules.txt
	k8s.io/legacy-cloud-providers: is replaced in go.mod, but not marked as replaced in vendor/modules.txt
	k8s.io/metrics: is replaced in go.mod, but not marked as replaced in vendor/modules.txt
	k8s.io/mount-utils: is replaced in go.mod, but not marked as replaced in vendor/modules.txt
	k8s.io/sample-apiserver: is replaced in go.mod, but not marked as replaced in vendor/modules.txt
	k8s.io/sample-cli-plugin: is replaced in go.mod, but not marked as replaced in vendor/modules.txt
	k8s.io/sample-controller: is replaced in go.mod, but not marked as replaced in vendor/modules.txt
	k8s.io/pod-security-admission: is replaced in go.mod, but not marked as replaced in vendor/modules.txt
	k8s.io/dynamic-resource-allocation: is replaced in go.mod, but not marked as replaced in vendor/modules.txt
	k8s.io/kms: is replaced in go.mod, but not marked as replaced in vendor/modules.txt
	k8s.io/endpointslice: is replaced in go.mod, but not marked as replaced in vendor/modules.txt
	k8s.io/autoscaler/cluster-autoscaler/apis: is replaced in go.mod, but not marked as replaced in vendor/modules.txt

	To ignore the vendor directory, use -mod=readonly or -mod=mod.
	To sync the vendor directory, run:
		go mod vendor
make: *** [Makefile:45: build-arch-amd64] Error 1
make: *** [Makefile:100: build-in-docker-arch-amd64] Error 2

@x13n
Copy link
Member

x13n commented May 9, 2024

FWIW, I pruned all cached containers and images and the result is still the same.

@fmuyassarov
Copy link
Member Author

FWIW, I pruned all cached containers and images and the result is still the same.

this is odd, but thanks for the try. I will try to reproduce it on my end.

@fmuyassarov
Copy link
Member Author

fmuyassarov commented May 9, 2024 •
edited
Loading

Hi @x13n ,
I gave it another shot, cleaned up (prune) all the docker stuff, and started fresh, but I still couldn't reproduce the issue again. I even tried using a GitHub Codespace, but no luck there either. Can you please give it a try with Codespace perhaps?

I could try in some other machine/vm/container but I expect that the result will be the same.

@x13n
Copy link
Member

x13n commented May 10, 2024

Must be something on my end. Both codespace and cloning a new repo on my machine worked correctly. No reason to block this PR then. Thanks for the contribution - I'm a fan of improvements with negative code delta and the one here is huge :)

/approve

I just noticed the warning in Makefile is going to become obsolete, can you drop it?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fmuyassarov, x13n

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2024
@fmuyassarov fmuyassarov force-pushed the devel/drop-vendor-dir branch from 336046b to f318381 Compare May 10, 2024 12:01
@fmuyassarov
Copy link
Member Author

fmuyassarov commented May 10, 2024 •
edited
Loading

I just noticed the warning in Makefile is going to become obsolete, can you drop it?

Good catch. Fixed.

@x13n
Copy link
Member

x13n commented May 10, 2024

Thanks!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 10, 2024
@k8s-ci-robot k8s-ci-robot merged commit 5ecf37a into kubernetes:master May 10, 2024
6 checks passed
@fmuyassarov fmuyassarov deleted the devel/drop-vendor-dir branch May 10, 2024 12:28
@Shubham82 Shubham82 mentioned this pull request Jun 3, 2024
Closed
@tenzen-y tenzen-y mentioned this pull request Jun 6, 2024
Closed
3 tasks
@fmuyassarov fmuyassarov mentioned this pull request Jun 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elmiko elmiko elmiko left review comments

@feiskyer feiskyer Awaiting requested review from feiskyer

@vadasambar vadasambar Awaiting requested review from vadasambar

@x13n x13n Awaiting requested review from x13n

Assignees

@x13n x13n

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fmuyassarov @vadasambar @x13n @k8s-ci-robot @elmiko