Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add vadasambar to cluster-autoscaler reviewers #6483

Merged

Conversation

vadasambar
Copy link
Member

Signed-off-by: vadasambar [email protected]

Requirements

From https://github.com/kubernetes/community/blob/4aac5c07b006acf242b9fddea7f67c7781e1eef7/community-membership.md#reviewer

  • member for at least 3 months I have been a member for more than a year (first PR)
  • Primary reviewer for at least 5 PRs to the codebase 8 of them merged (rest)
  • Reviewed or merged at least 20 substantial PRs to the codebase 20+ of them (12 merged, 8 reviewed) (rest)
  • Knowledgeable about the codebase Yes
  • Sponsored by a subproject approver
    • With no objections from other approvers
    • Done through PR to update the OWNERS file
  • May either self-nominate, be nominated by an approver in this subproject, or be nominated by a robot

/assign @gjtempleton

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 30, 2024
@k8s-ci-robot k8s-ci-robot requested a review from feiskyer January 30, 2024 17:52
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 30, 2024
@gjtempleton
Copy link
Member

/approve
Thanks for all your contributions so far, looking forward to more in the future!

@gjtempleton
Copy link
Member

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gjtempleton, vadasambar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Feb 5, 2024
@k8s-ci-robot k8s-ci-robot merged commit 85ef468 into kubernetes:master Feb 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants