storageclass permission is required #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
/assign @mwielgus @MaciekPytel |
| @@ -56,12 +56,36 @@ metadata: | |||
| k8s-app: cluster-autoscaler | |||
| rules: | |||
| - apiGroups: [""] | |||
| resources: ["configmaps"] | |||
| resources: ["events","endpoints"] | |||
There was a problem hiding this comment.
Why do all of these permissions need to be added to Role in addition to ClusterRole when running on master?
There was a problem hiding this comment.
oops, wrong place of new lines
| verbs: ["create"] | ||
| - apiGroups: [""] | ||
| resources: ["configmaps"] |
There was a problem hiding this comment.
What's the reason for removing permissions for writing configmap in this case?
There was a problem hiding this comment.
oops, wrong place of new lines
feiskyer
force-pushed
the
storageclass
branch
from
554cd52 to
96dae48
Compare
k8s-ci-robot
added
size/S
|
@aleksandra-malinowska Thanks of reviewing. Fixed permissions. PTAL |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
@mwielgus Thanks |
yaroslava-serdiuk
pushed a commit
to yaroslava-serdiuk/autoscaler
that referenced
this pull request
Feb 22, 2024
…a1-config Update documentation for config.kueue.x-k8s.io v1beta1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, cluster-autoscaler would report errors: