Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document useInstanceMetadata settings for Azure standard vmType #641

Merged
merged 1 commit into from
Feb 13, 2018

Conversation

feiskyer
Copy link
Member

@feiskyer feiskyer commented Feb 9, 2018

useInstanceMetadata should be set to false. Or else, node's providerID will be in azure://uuid format and autoscaler won't be able to recognize it.

In the future kubernetes releases, node's providerID will be updated to correct version (kubernetes/kubernetes#59539).

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 9, 2018
@feiskyer
Copy link
Member Author

/assign @mwielgus @MaciekPytel

@aleksandra-malinowska
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 13, 2018
@aleksandra-malinowska aleksandra-malinowska merged commit 04c5056 into kubernetes:master Feb 13, 2018
@feiskyer feiskyer deleted the document branch February 14, 2018 03:55
yaroslava-serdiuk pushed a commit to yaroslava-serdiuk/autoscaler that referenced this pull request Feb 22, 2024
…fig-to-beta

Graduate Configuration API version to v1beta1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cluster-autoscaler area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants