Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure: fix chart bugs after AKS vmType deprecation #6384

Merged

Conversation

jackfrancis
Copy link
Contributor

@jackfrancis jackfrancis commented Dec 15, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR fixes some chart errata introduced in #6186 (mea culpa). Specifically:

  • PR Azure: Remove AKS vmType #6186 removed the "AKS" vmType configuration, and so we don't to default the azureVMType chart value to be "AKS"
  • PR Azure: Remove AKS vmType #6186 removed the Azure provider "clusterName" configuration, so we don't want a reference to that as a required value in the chart deployment spec
  • PR Azure: Remove AKS vmType #6186 removed the Azure provider "nodeResourceGroup" configuration, so we don't want a reference to that as a required value in the chart deployment spec

Here is a representative example in PR #6186 of the removals mentioned above:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/helm-charts labels Dec 15, 2023
@jackfrancis jackfrancis force-pushed the azure-chart-fix-aks-deprecate branch from bcf75d8 to a0b0852 Compare December 15, 2023 22:29
@jackfrancis jackfrancis force-pushed the azure-chart-fix-aks-deprecate branch from a0b0852 to e28f9fd Compare December 15, 2023 22:34
Copy link
Contributor

@mwielgus mwielgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 19, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, mwielgus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 19, 2023
@k8s-ci-robot k8s-ci-robot merged commit 90361b4 into kubernetes:master Dec 19, 2023
6 checks passed
@jackfrancis jackfrancis deleted the azure-chart-fix-aks-deprecate branch January 8, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/helm-charts cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants