Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cluster-autoscaler-1.27] Update cloudprovider/aws/aws-sdk-go to 1.48.7 #6380

Conversation

ROunofF
Copy link
Contributor

@ROunofF ROunofF commented Dec 15, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it: Update cluster-autoscaler/cloudprovider/aws/aws-sdk-go to 1.48.7 so that we have support for dynamic auth token from file and EKS container host in absolute/relative URIs in the HTTP credential provider.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer: I kept the commit splitted for easier review : 1 commit is the bulk replace of the aws-sdk-go folder (~2900 files). In the other I changed the readme, added a line in the log.

Does this PR introduce a user-facing change?

Update cloudprovider/aws/aws-sdk-go to 1.48.7 so we support dynamic auth token

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


Remove *_test.go, models/, examples
+ Update version in README + command
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 15, 2023
@k8s-ci-robot k8s-ci-robot requested a review from drmorr0 December 15, 2023 20:25
Copy link
Contributor

@mwielgus mwielgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 18, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mwielgus, ROunofF

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2023
@k8s-ci-robot k8s-ci-robot merged commit d218e48 into kubernetes:cluster-autoscaler-release-1.27 Dec 18, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants