-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle error when listing machines #6298
fix: handle error when listing machines #6298
Conversation
Signed-off-by: Cyrill Troxler <[email protected]>
@x13n Saw your issue regarding the upcoming patch release, is it already too late or can I cherry pick this to be included? |
I'll be cutting patch releases on Tue/Wed. Note that if you want this change to end up on any of the existing minor branches, you need to cherrypick it there (i.e. to |
Merging this one. In the future, please consider joining the k8s community so you can approve changes for rancher cloudprovider yourself. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ctrox, ElanHasson, x13n The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Backport #6298 fix: handle error when listing machines into 1.27
Backport #6298 fix: handle error when listing machines into 1.26
Backport #6298 fix: handle error when listing machines into 1.28
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #5656
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: