Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle error when listing machines #6298

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

ctrox
Copy link
Contributor

@ctrox ctrox commented Nov 20, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #5656

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 20, 2023
@ctrox
Copy link
Contributor Author

ctrox commented Nov 20, 2023

@x13n Saw your issue regarding the upcoming patch release, is it already too late or can I cherry pick this to be included?

@x13n
Copy link
Member

x13n commented Nov 20, 2023

I'll be cutting patch releases on Tue/Wed. Note that if you want this change to end up on any of the existing minor branches, you need to cherrypick it there (i.e. to cluster-autoscaler-release-1.XX branches).

@x13n
Copy link
Member

x13n commented Nov 20, 2023

Merging this one. In the future, please consider joining the k8s community so you can approve changes for rancher cloudprovider yourself.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 20, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ctrox, ElanHasson, x13n

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2023
@k8s-ci-robot k8s-ci-robot merged commit dcaba44 into kubernetes:master Nov 20, 2023
4 checks passed
k8s-ci-robot added a commit that referenced this pull request Nov 21, 2023
Backport #6298 fix: handle error when listing machines into 1.27
k8s-ci-robot added a commit that referenced this pull request Nov 21, 2023
Backport #6298 fix: handle error when listing machines into 1.26
k8s-ci-robot added a commit that referenced this pull request Nov 21, 2023
Backport #6298 fix: handle error when listing machines into 1.28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autoscaler Rancher Provider Token Privileges Issue
4 participants