-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify simulation for removal log statement #6173
Clarify simulation for removal log statement #6173
Conversation
Welcome @kevin-bates! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the change! This looks good to me, leaving only one super minor comment. Feel free to cancel the hold if you disagree and want to merge as-is.
/lgtm
/approve
/hold
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kevin-bates, x13n The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks! /lgtm |
As the above nit is addressed, remove the hold label |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR helps improve supportability by improving the clarity of an informational logging statement that adds context for the log's reader. The message will go from:
to:
Previously, it was difficult to determine the for removal action. Also, prefixing the node's name with
node
is consistent with other node-named log statements.Which issue(s) this PR fixes:
Fixes #6170