Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Packet autoscaler cloudprovider updates #6078

Merged
merged 4 commits into from
Sep 14, 2023
Merged

Packet autoscaler cloudprovider updates #6078

merged 4 commits into from
Sep 14, 2023

Conversation

cprivitere
Copy link
Member

@cprivitere cprivitere commented Aug 30, 2023 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR updates the packet autoscaler in the following ways:

  • use https://api.equinix.com/metal/v1 instead of packet endpoint
  • remove old plans and add new plans
  • update plan pricing
  • update test to use current plan names
  • provide a source template file for the cloud-init used in example deployment
  • update RBAC in the example deployment to current requirements
  • add resource request for container to example deployment
  • use a tagged version instead of latest in example deployment
  • use control-plane instead of master for taint toleration in example deployment
  • Update embedded cloud init in example deployment so that is functional
  • Bump installed k8s in the example to 1.28.1

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

We now use metros in the Equinix Metal (Packet) cloudprovider. Facilities support has been removed.

Code was tested manually by deploying a build of the branch and testing that nodes could scale from zero.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 30, 2023
@k8s-ci-robot k8s-ci-robot requested a review from displague August 30, 2023 21:39
@k8s-ci-robot k8s-ci-robot requested a review from v-pap August 30, 2023 21:39
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 30, 2023
mwielgus
mwielgus approved these changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@mwielgus mwielgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 4, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cprivitere, mwielgus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Shubham82
Copy link
Contributor

@cprivitere please address the failed test which is required to be passed for the PR to merge

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 13, 2023
@cprivitere
feat: use current plan types and api endpoints
42db99c 
- use https://api.equinix.com/metal/v1/ instead of packet endpoint
- remove old plans
- add new plans
- update plan pricing
- update test to use current plan names, models, and results

Signed-off-by: Chris Privitere <[email protected]>
@cprivitere
feat: template for cloud-init used in example
cb53761 
Signed-off-by: Chris Privitere <[email protected]>
@cprivitere
feat: update deployment example
f78db16 
- update rbac to current requirements
- add resource request for container
- use a tagged version instead of latest
- use control-plane instead of master for taint toleration

Signed-off-by: Chris Privitere <[email protected]>
@cprivitere
feat: update secret example
b4e416f 
- Update embedded cloud init so it works
- Bump installed k8s to 1.28.1

Signed-off-by: Chris Privitere <[email protected]>
@Shubham82
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 14, 2023
@k8s-ci-robot k8s-ci-robot merged commit 3b08870 into kubernetes:master Sep 14, 2023
@cprivitere cprivitere deleted the packet-updates branch September 14, 2023 17:52
@displague
Copy link
Member

Fixes #5855
Fixes #4287

@displague displague mentioned this pull request Feb 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwielgus mwielgus mwielgus approved these changes

@displague displague Awaiting requested review from displague

@v-pap v-pap Awaiting requested review from v-pap

Assignees

@mwielgus mwielgus

@Shubham82 Shubham82

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cprivitere @k8s-ci-robot @Shubham82 @displague @mwielgus