-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Process annotation marking pod as not safe to evict first #6077
Process annotation marking pod as not safe to evict first #6077
Conversation
By processing this annotation first, pods that would match also other, subsequent rules (e.g. pods without a controller), will generate the `NotSafeToEvictAnnotation` instead of e.g. `NotReplicated`. This allows marking pods as not safe to evict to change the warning to one that can be more effectively ignored, e.g. for ephemeral build pods that are known to not be backed by a controller, and should not be evicted.
|
Welcome @lauraseidler! |
The change is slightly user-facing, but the warnings are not generally expected to be a stable interface anyway. If you want, you can edit the description to include something like 'Pods with the "cluster-autoscaler.kubernetes.io/safe-to-evict": "true" annotation will now always report an annotation-related warning message if they block scale-down (where previously they might've reported e.g. a message about not being replicated).' /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lauraseidler, towca The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
By processing this annotation first, pods that would match also other, subsequent rules (e.g. pods without a controller), will generate the
NotSafeToEvictAnnotation
instead of e.g.NotReplicated
.This allows marking pods as not safe to evict to change the warning to one that can be more effectively ignored, e.g. for ephemeral build pods that are known to not be backed by a controller, and should not be evicted.
Which issue(s) this PR fixes:
Fixes #5434
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: