Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added s390x support #6020

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Conversation

Saripalli-lavanya
Copy link
Contributor

What type of PR is this?

This PR adds docker file for s390x arch

What this PR does / why we need it:

This PR can help build s390x auto scalar image

Which issue(s) this PR fixes:

Fixes # NA

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

None

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 7, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: Saripalli-lavanya (3c38918)

@k8s-ci-robot k8s-ci-robot added area/cluster-autoscaler cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 7, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @Saripalli-lavanya!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 7, 2023
@Shubham82
Copy link
Contributor

Hi @Saripalli-lavanya
Please sign the CLA before the PR can be reviewed.
See the following document to sign the CLA: Signing Contributor License Agreements(CLA)

@Shubham82
Copy link
Contributor

To check CLA,

/easycla

@spzala
Copy link
Member

spzala commented Aug 8, 2023

/easycla

CLA in progress @Saripalli-lavanya thx!

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 9, 2023
@Saripalli-lavanya
Copy link
Contributor Author

Thank you @spzala, CLA Completed now

@Saripalli-lavanya
Copy link
Contributor Author

Hi@Shubham82, Could you help me take this PR review ahead, CLA has been completed, logs from my local JFR.

saripallilavanya@Lavanyas-MacBook-Pro cluster-autoscaler % make container
rm -f cluster-autoscaler-s390x
docker build --network=default -t autoscaling-builder ../builder
[+] Building 11.9s (3/8)                                                                                           [+] Building 12.0s (3/8)                                                                                           [+] Building 100.2s (9/9) FINISHED                                                                                 
 => [internal] load build definition from Dockerfile                                                          0.0ss
 => => transferring dockerfile: 936B                                                                          0.0ss
 => [internal] load .dockerignore                                                                             0.0ss
 => => transferring context: 2B                                                                               0.0ss
 => [internal] load metadata for docker.io/library/golang:1.20.4                                              7.0ss
 => [1/5] FROM docker.io/library/golang:1.20.4@sha256:690e4135bf2a4571a572bfd5ddfa806b1cb9c3dea0446ebadaf32  67.6ss
 => => resolve docker.io/library/golang:1.20.4@sha256:690e4135bf2a4571a572bfd5ddfa806b1cb9c3dea0446ebadaf32b  0.0ss
 => => sha256:690e4135bf2a4571a572bfd5ddfa806b1cb9c3dea0446ebadaf32bc2ea09d4f9 2.36kB / 2.36kB                0.0ss
 => => sha256:3fccedea46315261e4b6205bcffe91ece1e2aea60c23aab0f033f35461849b42 1.58kB / 1.58kB                0.0s
 => => sha256:6a90a37099af57552e523ac8cd1fb470b85dd559c2f9e8453e62dc3bf9163a49 6.99kB / 6.99kB                0.0s
 => => sha256:bd73737482dd5575526c7207872963479808d979ab2741c321706b8553918474 55.05MB / 55.05MB             19.4s
 => => sha256:6710592d62aa1338ac1c1c363dedc255659f666cc41441c7e0f735c484db10ff 15.76MB / 15.76MB             15.6s
 => => sha256:75256935197ed1bb3b994a77c01efa00349b901014448a260fafd9c3719a741d 54.58MB / 54.58MB             41.6s
 => => sha256:948a624948bad16368a8875d007bc505810d290412e61357e0e44549e775dd3c 86.03MB / 86.03MB             58.9s
 => => extracting sha256:bd73737482dd5575526c7207872963479808d979ab2741c321706b8553918474                     3.4s
 => => sha256:147e02c24f40116f23669411aa9b2a6b2f964ddce0e045d3933cc4ad19337cb3 100.15MB / 100.15MB           62.8s
 => => extracting sha256:6710592d62aa1338ac1c1c363dedc255659f666cc41441c7e0f735c484db10ff                     0.7s
 => => sha256:cd56b3199c0c96901ea545187395ab9d886e75aeb4d953f018a21c5782dc9498 156B / 156B                   44.7s
 => => extracting sha256:75256935197ed1bb3b994a77c01efa00349b901014448a260fafd9c3719a741d                     3.7s
 => => extracting sha256:948a624948bad16368a8875d007bc505810d290412e61357e0e44549e775dd3c                     4.4s
 => => extracting sha256:147e02c24f40116f23669411aa9b2a6b2f964ddce0e045d3933cc4ad19337cb3                     3.8s
 => => extracting sha256:cd56b3199c0c96901ea545187395ab9d886e75aeb4d953f018a21c5782dc9498                     0.0s
 => [2/5] RUN apt-get update && apt-get --yes install libseccomp-dev                                          6.0s
 => [3/5] RUN go version                                                                                      0.5s 
 => [4/5] RUN go get github.com/tools/godep                                                                  18.2s 
 => [5/5] RUN godep version                                                                                   0.4s 
 => exporting to image                                                                                        0.4s 
 => => exporting layers                                                                                       0.4s 
 => => writing image sha256:c4cdcd088b9deab3ffff18773449d422c5087e03d86925d1dd9777c0a3f3e061                  0.0s 
 => => naming to docker.io/library/autoscaling-builder                                                        0.0s
docker run  -v `pwd`:/gopath/src/k8s.io/autoscaler/cluster-autoscaler/:Z autoscaling-builder:latest \
                bash -c 'cd /gopath/src/k8s.io/autoscaler/cluster-autoscaler && BUILD_TAGS= LDFLAGS="-s" make build-arch-s390x'
rm -f cluster-autoscaler-s390x
CGO_ENABLED=0 GOOS=linux GOARCH=s390x go build -o cluster-autoscaler-s390x --ldflags "-s" 
docker build --pull \
                -t staging-k8s.gcr.io/cluster-autoscaler-s390x:dev \
                -f Dockerfile.s390x .
[+] Building 5.7s (7/7) FINISHED                                                                                                     
 => [internal] load build definition from Dockerfile.s390x                                                                      0.0s
 => => transferring dockerfile: 38B                                                                                             0.0s
 => [internal] load .dockerignore                                                                                               0.0s
 => => transferring context: 2B                                                                                                 0.0s
 => [internal] load metadata for gcr.io/distroless/static:nonroot-s390x                                                         2.9s
 => [internal] load build context                                                                                               1.6s
 => => transferring context: 164.07MB                                                                                           1.6s
 => CACHED [1/3] FROM gcr.io/distroless/static:nonroot-s390x@sha256:c0e2f22015a1f262d73a340cb5bc58637b8cc9416c20b5be6a2bdc9e90  0.0s
 => [2/3] COPY cluster-autoscaler-s390x /cluster-autoscaler                                                                     0.5s
 => exporting to image                                                                                                          0.6s
 => => exporting layers                                                                                                         0.6s
 => => writing image sha256:05952014a6f4ad3cc8e58a31bb5747412dce6e5c5ce949fe4545218fac2d45a4                                    0.0s
 => => naming to staging-k8s.gcr.io/cluster-autoscaler-s390x:dev                                                                0.0s
Image dev-s390x completed
Full in-docker image dev-s390x completed
saripallilavanya@Lavanyas-MacBook-Pro cluster-autoscaler % docker image ls
REPOSITORY                                                  TAG                                              IMAGE ID       CREATED          SIZE
staging-k8s.gcr.io/cluster-autoscaler-s390x                 dev                                              05952014a6f4   2 minutes ago    166MB
autoscaling-builder                                         latest                                           c4cdcd088b9d   8 minutes ago    887MB
<none>                                                      <none>                                           2bcce1512624   11 minutes ago   167MB

@Shubham82
Copy link
Contributor

Thanks @Saripalli-lavanya
IMO, Supporting more arches is good for CA, but let's take the opinion of who maintains the images for CA.

@mwielgus @gjtempleton @MaciekPytel @BigDarkClown your thoughts on this?

@Saripalli-lavanya Saripalli-lavanya changed the title Create Dockerfile.s390x Added s390x support Aug 9, 2023
Copy link
Contributor

@mwielgus mwielgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 10, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mwielgus, Saripalli-lavanya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2023
@k8s-ci-robot k8s-ci-robot merged commit 1aaf4d0 into kubernetes:master Aug 10, 2023
k8s-ci-robot added a commit that referenced this pull request Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants