Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow using an externally created secret instead of using the one the Helm chart creates #6016

Merged
merged 1 commit into from
Aug 22, 2023
Merged

Allow using an externally created secret instead of using the one the Helm chart creates #6016

merged 1 commit into from
Aug 22, 2023

Conversation

mtougeron
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

This allows you to define a Secret that was created outside the Helm chart for the Azure (or AWS) cluster-autoscaler configuration so that the secret can be securely added to Kubernetes. A common method of this would be the external-secrets-operator or vault-secrets-operator.

Which issue(s) this PR fixes:

Fixes # n/a

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Allow using an externally created secret instead of using the one the Helm chart creates

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 4, 2023
@mtougeron
Copy link
Contributor Author

/label helm-charts

@k8s-ci-robot
Copy link
Contributor

@mtougeron: The label(s) /label helm-charts cannot be applied. These labels are supported: api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda, refactor. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label helm-charts

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rdtiu
rdtiu approved these changes Aug 8, 2023
View reviewed changes
Copy link

@rdtiu rdtiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

@rdtiu: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mwielgus
mwielgus approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@mwielgus mwielgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 22, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mtougeron, mwielgus, rdtiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 22, 2023
@k8s-ci-robot k8s-ci-robot merged commit 5e20c44 into kubernetes:master Aug 22, 2023
@mtougeron mtougeron deleted the flexible-secret-name branch August 23, 2023 16:38
@mtougeron
Copy link
Contributor Author

Thanks @mwielgus !

@gjtempleton gjtempleton mentioned this pull request Aug 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwielgus mwielgus mwielgus approved these changes

@rdtiu rdtiu rdtiu approved these changes

@gjtempleton gjtempleton Awaiting requested review from gjtempleton

@MaciekPytel MaciekPytel Awaiting requested review from MaciekPytel

Assignees

@mwielgus mwielgus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/helm-charts cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mtougeron @k8s-ci-robot @rdtiu @mwielgus