Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update RBAC to only use verbs that exist for the resources #5927

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

MaxRink
Copy link
Contributor

@MaxRink MaxRink commented Jul 5, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR adjusts the RBAC for the CAPI mode in a way that only verbs that the API-Server knows are used for resources.
This is mostly helpful for people that auto generate their RBAC from the kube API-Server

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 5, 2023
@k8s-ci-robot k8s-ci-robot requested a review from gjtempleton July 5, 2023 10:46
@k8s-ci-robot k8s-ci-robot requested a review from MaciekPytel July 5, 2023 10:46
Copy link
Contributor

@mwielgus mwielgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 24, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MaxRink, mwielgus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 24, 2023
@k8s-ci-robot k8s-ci-robot merged commit 57d07df into kubernetes:master Aug 24, 2023
@gjtempleton
Copy link
Member

Hey @MaxRink, unfortunately due to the checks for version bumping only running on the initial PR, this version of the chart can't be published as #6016 was merged first, bumping to the same version. Can you raise 2 new PRs, one reverting this, then another with these changes plus bumping the version again to 1.29.3 and we can get this published?

@MaxRink
Copy link
Contributor Author

MaxRink commented Aug 28, 2023

@gjtempleton sure
#6067
reverts it

Edit:
give that the linter complains on that MR as the chart is changed with no version change it might be easier to just bump the chart version instead of reverting and reapplying

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/helm-charts cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants