-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the AppVersion to labels as app.kubernetes.io/version #6012
Add the AppVersion to labels as app.kubernetes.io/version #6012
Conversation
Welcome @jw-maynard! |
A similar PR opened previously but was not merged due to unsign easyCLA, Here is the following PR:#5874 |
@gjtempleton @mwielgus any chance of getting this reviewed? Thanks |
30d2ce8
to
1b69238
Compare
Sorry for the delay on this, thanks for the PR! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gjtempleton, jw-maynard The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@Shubham82 can you please give this a final review and lgtm if it looks good as I've now contributed to the PR as well. Thanks. |
/lgtm |
What type of PR is this?
/kind feature
What this PR does / why we need it:
It adds the AppVersion of the Helm chart to the common labels as the recommended standard label
app.kubernetes.io/version
Which issue(s) this PR fixes:
Fixes None
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: