Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PostPackingFunc to be run at the end of the estimation logic #5974

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Add PostPackingFunc to be run at the end of the estimation logic #5974

merged 1 commit into from
Jul 26, 2023

Conversation

azylinski
Copy link
Contributor

What type of PR is this?

/kind refactor

What this PR does / why we need it:

Add PostPackingFunc, so the BinPackingEstimator can be extended easily.

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot
Copy link
Contributor

@azylinski: The label(s) kind/refactor cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind refactor

What this PR does / why we need it:

Add PostPackingFunc, so the BinPackingEstimator can be extended easily.

Does this PR introduce a user-facing change?

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 20, 2023
jayantjain93
jayantjain93 reviewed Jul 21, 2023
View reviewed changes
Copy link
Contributor

@jayantjain93 jayantjain93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit, rest LGTM.

/lgtm

cluster-autoscaler/estimator/estimator.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 21, 2023
@azylinski azylinski force-pushed the add-estimator-PostPackingFunc branch from 2e9b54d to 21229d3 Compare July 25, 2023 07:22
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 25, 2023
@BigDarkClown
Copy link
Contributor

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 26, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: azylinski, BigDarkClown

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2023
@k8s-ci-robot k8s-ci-robot merged commit 63eab4e into kubernetes:master Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayantjain93 jayantjain93 jayantjain93 left review comments

@BigDarkClown BigDarkClown Awaiting requested review from BigDarkClown

@feiskyer feiskyer Awaiting requested review from feiskyer

Assignees

@jayantjain93 jayantjain93

@BigDarkClown BigDarkClown

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@azylinski @k8s-ci-robot @BigDarkClown @jayantjain93